* [PATCH] [libstdc++] xfail noreplace tests on vxworks
@ 2023-02-17 7:40 Alexandre Oliva
2023-02-17 11:00 ` Jonathan Wakely
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Oliva @ 2023-02-17 7:40 UTC (permalink / raw)
To: gcc-patches, libstdc++
vxworks ignores O_EXCL in open, so noreplace open succeeds when it is
expected to fail. xfail the tests.
Regstrapped on x86_64-linux-gnu.
Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install?
for libstdc++-v3/ChangeLog
* testsuite/27_io/basic_ofstream/open/char/noreplace.cc: xfail
on vxworks.
* testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc:
Likewise.
---
.../27_io/basic_ofstream/open/char/noreplace.cc | 2 +-
.../27_io/basic_ofstream/open/wchar_t/noreplace.cc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
index 56ff2d7cead3c..2e99707df86d0 100644
--- a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
+++ b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
@@ -1,4 +1,4 @@
-// { dg-do run }
+// { dg-do run { xfail *-*-vxworks* } }
#include <ios>
diff --git a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
index f0425cdab3d23..ddb7fd691608c 100644
--- a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
+++ b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
@@ -1,4 +1,4 @@
-// { dg-do run }
+// { dg-do run { xfail *-*-vxworks* } }
#include <version>
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [libstdc++] xfail noreplace tests on vxworks
2023-02-17 7:40 [PATCH] [libstdc++] xfail noreplace tests on vxworks Alexandre Oliva
@ 2023-02-17 11:00 ` Jonathan Wakely
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2023-02-17 11:00 UTC (permalink / raw)
To: Alexandre Oliva; +Cc: gcc-patches, libstdc++
[-- Attachment #1: Type: text/plain, Size: 2091 bytes --]
On Fri, 17 Feb 2023, 07:40 Alexandre Oliva via Libstdc++, <
libstdc++@gcc.gnu.org> wrote:
>
> vxworks ignores O_EXCL in open, so noreplace open succeeds when it is
> expected to fail. xfail the tests.
>
> Regstrapped on x86_64-linux-gnu.
> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install?
>
OK, thanks.
(We need a similar change for hp-ux and Solaris, at least. Which means we
need to change the impl to not assume it works.)
> for libstdc++-v3/ChangeLog
>
> * testsuite/27_io/basic_ofstream/open/char/noreplace.cc: xfail
> on vxworks.
> * testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc:
> Likewise.
> ---
> .../27_io/basic_ofstream/open/char/noreplace.cc | 2 +-
> .../27_io/basic_ofstream/open/wchar_t/noreplace.cc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> index 56ff2d7cead3c..2e99707df86d0 100644
> --- a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> +++ b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> @@ -1,4 +1,4 @@
> -// { dg-do run }
> +// { dg-do run { xfail *-*-vxworks* } }
>
> #include <ios>
>
> diff --git
> a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> index f0425cdab3d23..ddb7fd691608c 100644
> --- a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> +++ b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> @@ -1,4 +1,4 @@
> -// { dg-do run }
> +// { dg-do run { xfail *-*-vxworks* } }
>
> #include <version>
>
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-17 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 7:40 [PATCH] [libstdc++] xfail noreplace tests on vxworks Alexandre Oliva
2023-02-17 11:00 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).