public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] gcov: Respect tripplet when looking for gcov
@ 2022-09-09 10:27 Torbjörn SVENSSON
  2022-09-09 11:46 ` Martin Liška
  2022-09-09 11:56 ` Rainer Orth
  0 siblings, 2 replies; 3+ messages in thread
From: Torbjörn SVENSSON @ 2022-09-09 10:27 UTC (permalink / raw)
  To: gcc-patches
  Cc: hubicka, mliska, nathan, ro, mikestump, Torbjörn SVENSSON

When testing a cross toolchain outside the build tree, the binary name
for gcov is prefixed with the tripplet.

gcc/testsuite/ChangeLog:

        * g++.dg/gcov/gcov.exp: Respect tripplet when looking for gcov
        * gcc.misc-tests/gcov.exp: Likewise

Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
---
 gcc/testsuite/g++.dg/gcov/gcov.exp    | 4 ++--
 gcc/testsuite/gcc.misc-tests/gcov.exp | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/gcc/testsuite/g++.dg/gcov/gcov.exp b/gcc/testsuite/g++.dg/gcov/gcov.exp
index 88acd95c361..04e7a016486 100644
--- a/gcc/testsuite/g++.dg/gcov/gcov.exp
+++ b/gcc/testsuite/g++.dg/gcov/gcov.exp
@@ -24,9 +24,9 @@ global GXX_UNDER_TEST
 
 # Find gcov in the same directory as $GXX_UNDER_TEST.
 if { ![is_remote host] && [string match "*/*" [lindex $GXX_UNDER_TEST 0]] } {
-    set GCOV [file dirname [lindex $GXX_UNDER_TEST 0]]/gcov
+    set GCOV [file dirname [lindex $GXX_UNDER_TEST 0]]/[transform gcov]
 } else {
-    set GCOV gcov
+    set GCOV [transform gcov]
 }
 
 # Initialize harness.
diff --git a/gcc/testsuite/gcc.misc-tests/gcov.exp b/gcc/testsuite/gcc.misc-tests/gcov.exp
index 82376d90ac2..a55ce234f6e 100644
--- a/gcc/testsuite/gcc.misc-tests/gcov.exp
+++ b/gcc/testsuite/gcc.misc-tests/gcov.exp
@@ -24,9 +24,9 @@ global GCC_UNDER_TEST
 
 # For now find gcov in the same directory as $GCC_UNDER_TEST.
 if { ![is_remote host] && [string match "*/*" [lindex $GCC_UNDER_TEST 0]] } {
-    set GCOV [file dirname [lindex $GCC_UNDER_TEST 0]]/gcov
+    set GCOV [file dirname [lindex $GCC_UNDER_TEST 0]]/[transform gcov]
 } else {
-    set GCOV gcov
+    set GCOV {transform gcov]
 }
 
 # Initialize harness.
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gcov: Respect tripplet when looking for gcov
  2022-09-09 10:27 [PATCH] gcov: Respect tripplet when looking for gcov Torbjörn SVENSSON
@ 2022-09-09 11:46 ` Martin Liška
  2022-09-09 11:56 ` Rainer Orth
  1 sibling, 0 replies; 3+ messages in thread
From: Martin Liška @ 2022-09-09 11:46 UTC (permalink / raw)
  To: Torbjörn SVENSSON, gcc-patches; +Cc: hubicka, nathan, ro, mikestump

On 9/9/22 12:27, Torbjörn SVENSSON wrote:
> When testing a cross toolchain outside the build tree, the binary name
> for gcov is prefixed with the tripplet.

Ok, thanks!

Martin

> 
> gcc/testsuite/ChangeLog:
> 
>         * g++.dg/gcov/gcov.exp: Respect tripplet when looking for gcov
>         * gcc.misc-tests/gcov.exp: Likewise
> 
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
>  gcc/testsuite/g++.dg/gcov/gcov.exp    | 4 ++--
>  gcc/testsuite/gcc.misc-tests/gcov.exp | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/gcc/testsuite/g++.dg/gcov/gcov.exp b/gcc/testsuite/g++.dg/gcov/gcov.exp
> index 88acd95c361..04e7a016486 100644
> --- a/gcc/testsuite/g++.dg/gcov/gcov.exp
> +++ b/gcc/testsuite/g++.dg/gcov/gcov.exp
> @@ -24,9 +24,9 @@ global GXX_UNDER_TEST
>  
>  # Find gcov in the same directory as $GXX_UNDER_TEST.
>  if { ![is_remote host] && [string match "*/*" [lindex $GXX_UNDER_TEST 0]] } {
> -    set GCOV [file dirname [lindex $GXX_UNDER_TEST 0]]/gcov
> +    set GCOV [file dirname [lindex $GXX_UNDER_TEST 0]]/[transform gcov]
>  } else {
> -    set GCOV gcov
> +    set GCOV [transform gcov]
>  }
>  
>  # Initialize harness.
> diff --git a/gcc/testsuite/gcc.misc-tests/gcov.exp b/gcc/testsuite/gcc.misc-tests/gcov.exp
> index 82376d90ac2..a55ce234f6e 100644
> --- a/gcc/testsuite/gcc.misc-tests/gcov.exp
> +++ b/gcc/testsuite/gcc.misc-tests/gcov.exp
> @@ -24,9 +24,9 @@ global GCC_UNDER_TEST
>  
>  # For now find gcov in the same directory as $GCC_UNDER_TEST.
>  if { ![is_remote host] && [string match "*/*" [lindex $GCC_UNDER_TEST 0]] } {
> -    set GCOV [file dirname [lindex $GCC_UNDER_TEST 0]]/gcov
> +    set GCOV [file dirname [lindex $GCC_UNDER_TEST 0]]/[transform gcov]
>  } else {
> -    set GCOV gcov
> +    set GCOV {transform gcov]
>  }
>  
>  # Initialize harness.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gcov: Respect tripplet when looking for gcov
  2022-09-09 10:27 [PATCH] gcov: Respect tripplet when looking for gcov Torbjörn SVENSSON
  2022-09-09 11:46 ` Martin Liška
@ 2022-09-09 11:56 ` Rainer Orth
  1 sibling, 0 replies; 3+ messages in thread
From: Rainer Orth @ 2022-09-09 11:56 UTC (permalink / raw)
  To: Torbjörn SVENSSON; +Cc: gcc-patches, hubicka, mliska, nathan, mikestump

Hi Torbjörn,

> When testing a cross toolchain outside the build tree, the binary name
> for gcov is prefixed with the tripplet.

here and below: the beast is called triplet.

> gcc/testsuite/ChangeLog:
>
>         * g++.dg/gcov/gcov.exp: Respect tripplet when looking for gcov
>         * gcc.misc-tests/gcov.exp: Likewise

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-09 11:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-09 10:27 [PATCH] gcov: Respect tripplet when looking for gcov Torbjörn SVENSSON
2022-09-09 11:46 ` Martin Liška
2022-09-09 11:56 ` Rainer Orth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).