Re: libstdc++/4071: "make install" installs .../include/g++-v3/Makefile

Re: libstdc++/4071: "make install" installs .../include/g++-v3/Makefile

[pme]

Synopsis: "make install" installs .../include/g++-v3/Makefile

State-Changed-From-To: feedback->closed
State-Changed-By: pme
State-Changed-When: Wed Oct 10 13:40:38 2001
State-Changed-Why:
    Fixed in 3.0.2.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view&pr=4071&database=gcc

Re: libstdc++/4071: "make install" installs .../include/g++-v3/Makefile

[bkoz]

Synopsis: "make install" installs .../include/g++-v3/Makefile

Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Fri Aug 24 17:15:35 2001
Responsible-Changed-Why:
    Mine.
State-Changed-From-To: open->feedback
State-Changed-By: bkoz
State-Changed-When: Fri Aug 24 17:15:35 2001
State-Changed-Why:
    Fixed this a bit ago in mainline. I'll check it in on the branch now.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view&pr=4071&database=gcc

Re: libstdc++/4071: "make install" installs .../include/g++-v3/Makefile

[Phil Edwards]

The following reply was made to PR libstdc++/4071; it has been noted by GNATS.

From: Phil Edwards <pedwards@disaster.jaj.com>
To: gcc-gnats@gcc.gnu.org
Cc:  
Subject: Re: libstdc++/4071: "make install" installs .../include/g++-v3/Makefile
Date: Wed, 22 Aug 2001 17:25:38 -0400

 On Wed, Aug 22, 2001 at 01:06:00AM -0000, Phil Edwards wrote:
 >  That's... amusing.  Happening here too, although not on the 3.1 branch.
 >  A quick look at the differences between the branches doesn't point out
 >  anything obvious to me, but it was just a quick look.
 
 Obviously I'm blind.  A simple annotation search points to this on mainline:
 
     2001-08-07  Benjamin Kosnik  <bkoz@redhat.com>
 
             Implement std::messages.
 [...]
             * include/Makefile.am (install-data-local): Don't install Makefile.
 
 So this will be fixed whenever this patch goes over into the branch.
 Since it isn't a critical issue, there's no point in making the future
 merging any more difficult than it usually is by moving pieces of the
 patch early.  In the meantime we'll just have to hope that nobody chdir's
 into the header installation directory and types 'make'.  :-)
 
 
 Phil
 
 -- 
 Would I had phrases that are not known, utterances that are strange, in
 new language that has not been used, free from repetition, not an utterance
 which has grown stale, which men of old have spoken.
                                      - anonymous Egyptian scribe, c.1700 BC

Re: libstdc++/4071: "make install" installs .../include/g++-v3/Makefile

[Phil Edwards]

The following reply was made to PR libstdc++/4071; it has been noted by GNATS.

From: Phil Edwards <pedwards@disaster.jaj.com>
To: Phil Richards <pgr@derived-software.demon.co.uk>
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: libstdc++/4071: "make install" installs .../include/g++-v3/Makefile
Date: Tue, 21 Aug 2001 19:37:58 -0400

 On Tue, Aug 21, 2001 at 12:00:55PM +0100, Phil Richards wrote:
 > I keep a list of all files installed (for later clean-up), and when
 > cross-checking what needed keeping between gcc 3.0 and gcc 3.0.1
 > noticed that
 >     /usr/local/include/g++-v3/Makefile
 > existed in 3.0.1 and not 3.0.
 
 That's... amusing.  Happening here too, although not on the 3.1 branch.
 A quick look at the differences between the branches doesn't point out
 anything obvious to me, but it was just a quick look.
 
 
 > >Fix:
 > gcc-3.0.1/libstdc++-v3/include/Makefile.am:420 needs to exclude Makefile.
 > 
 > Quick (tested on GNU find) hack:
 
 I'll look this over tomorrow and apply it if it works okay.  Thanks!
 
 
 Phil
 
 -- 
 Would I had phrases that are not known, utterances that are strange, in
 new language that has not been used, free from repetition, not an utterance
 which has grown stale, which men of old have spoken.
                                      - anonymous Egyptian scribe, c.1700 BC

libstdc++/4071: "make install" installs .../include/g++-v3/Makefile

[Phil Richards]

>Number:         4071
>Category:       libstdc++
>Synopsis:       "make install" installs .../include/g++-v3/Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 21 10:16:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Phil Richards
>Release:        3.0.1
>Organization:
Derived Software Limited
>Environment:
System: Linux derisoft.derived-software.demon.co.uk 2.4.5-5mdk #1 Sat Jun 16 08:08:07 EDT 2001 i686 unknown
Architecture: i686

host: i686-pc-linux-gnu
build: i686-pc-linux-gnu
target: i686-pc-linux-gnu
configured with: ../gcc-3.0.1/configure --prefix=/usr/local --enable-threads
>Description:

[I couldn't work out which category/class problems like this should go
under ... there doesn't appear to be an "install" class.]

Did "make bootstrap" as "normal user", and "make install" as root.
I keep a list of all files installed (for later clean-up), and when
cross-checking what needed keeping between gcc 3.0 and gcc 3.0.1
noticed that
    /usr/local/include/g++-v3/Makefile
existed in 3.0.1 and not 3.0.

A quick check showed that this was a copy of
    <builddir>/i686-pc-linux-gnu/libstdc++-v3/include/Makefile

The install-data-local: rule from that Makefile installs all
files in the directory (except stamp-*) into .../include/g++-v3;
this, of course, includes "Makefile".

>How-To-Repeat:

make bootstrap
make install

(not double checked, but that's what I did to cause it!)

>Fix:
gcc-3.0.1/libstdc++-v3/include/Makefile.am:420 needs to exclude Makefile.

Quick (tested on GNU find) hack:

diff -Nc3pad gcc-3.0.1/libstdc++-v3/include/Makefile.am gcc-3.0.1-pgr/libstdc++-v3/include/Makefile.am
*** gcc-3.0.1/libstdc++-v3/include/Makefile.am	Fri Aug 17 22:03:40 2001
--- gcc-3.0.1-pgr/libstdc++-v3/include/Makefile.am	Tue Aug 21 11:50:41 2001*************** ${thread_builddir}/gthr-default.h:
*** 417,423 ****
  gxx_include_dir = @gxx_include_dir@
  
  install-data-local:
! 	for file in `find . ! -name stamp-\* -print`; do \
  	installFile=${gxx_include_dir}/$${file} ;\
  	if [ -d $${file} ]; then \
  	  $(INSTALL) -d $${installFile} ;\
--- 417,423 ----
  gxx_include_dir = @gxx_include_dir@
  
  install-data-local:
! 	for file in `find . ! -name stamp-\* ! -name Makefile -print`; do \
  	installFile=${gxx_include_dir}/$${file} ;\
  	if [ -d $${file} ]; then \
  	  $(INSTALL) -d $${installFile} ;\
>Release-Note:
>Audit-Trail:
>Unformatted: