public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
* Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address
@ 2002-12-21 9:04 bangerth
0 siblings, 0 replies; 5+ messages in thread
From: bangerth @ 2002-12-21 9:04 UTC (permalink / raw)
To: dje, gcc-bugs, gcc-prs, john, nobody
Synopsis: cselib.c hash_rtx incorrectly hashes based on rtx address
State-Changed-From-To: open->feedback
State-Changed-By: bangerth
State-Changed-When: Sat Dec 21 09:04:44 2002
State-Changed-Why:
David, you probably have more insight into these things than
me, but I know that some of these address-hashing things
have been purged. Is this particular report still valid?
Thanks
Wolfgang
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=4520
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address
@ 2002-12-21 23:06 Geoff Keating
0 siblings, 0 replies; 5+ messages in thread
From: Geoff Keating @ 2002-12-21 23:06 UTC (permalink / raw)
To: nobody; +Cc: gcc-prs
The following reply was made to PR other/4520; it has been noted by GNATS.
From: Geoff Keating <geoffk@geoffk.org>
To: dje@watson.ibm.com
Cc: bangerth@dealii.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
john@feith.com, nobody@gcc.gnu.org, gcc-gnats@gcc.gnu.org
Subject: Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address
Date: Sat, 21 Dec 2002 22:56:59 -0800
> Cc: Geoff Keating <geoffk@geoffk.org>
> Date: Sat, 21 Dec 2002 13:22:13 -0500
> From: David Edelsohn <dje@watson.ibm.com>
> X-OriginalArrivalTime: 21 Dec 2002 18:22:33.0209 (UTC) FILETIME=[EE029E90:01C2A91D]
>
> >>>>> bangerth writes:
>
> Wolfgang> David, you probably have more insight into these things than
> Wolfgang> me, but I know that some of these address-hashing things
> Wolfgang> have been purged. Is this particular report still valid?
>
> As far as I can tell, the incorrect hashing of addresses of
> LABEL_REFS and SYMBOL_REFS in cselib.c:hash_rtx() has not been corrected.
> The failure is dormant, but I am not sure how it affects PCH restore
> state.
cselib.c isn't active when PCH files are saved, so nothing in cselib.c
affects PCH.
--
- Geoffrey Keating <geoffk@geoffk.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address
@ 2002-12-21 10:29 bangerth
0 siblings, 0 replies; 5+ messages in thread
From: bangerth @ 2002-12-21 10:29 UTC (permalink / raw)
To: dje, gcc-bugs, gcc-prs, john, nobody
Synopsis: cselib.c hash_rtx incorrectly hashes based on rtx address
State-Changed-From-To: feedback->open
State-Changed-By: bangerth
State-Changed-When: Sat Dec 21 10:29:40 2002
State-Changed-Why:
Probably still exists. Thanks for the quick feedback, David!
W.
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=4520
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address
@ 2002-12-21 10:26 David Edelsohn
0 siblings, 0 replies; 5+ messages in thread
From: David Edelsohn @ 2002-12-21 10:26 UTC (permalink / raw)
To: nobody; +Cc: gcc-prs
The following reply was made to PR other/4520; it has been noted by GNATS.
From: David Edelsohn <dje@watson.ibm.com>
To: bangerth@dealii.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
john@feith.com, nobody@gcc.gnu.org, gcc-gnats@gcc.gnu.org
Cc: Geoff Keating <geoffk@geoffk.org>
Subject: Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address
Date: Sat, 21 Dec 2002 13:22:13 -0500
>>>>> bangerth writes:
Wolfgang> David, you probably have more insight into these things than
Wolfgang> me, but I know that some of these address-hashing things
Wolfgang> have been purged. Is this particular report still valid?
As far as I can tell, the incorrect hashing of addresses of
LABEL_REFS and SYMBOL_REFS in cselib.c:hash_rtx() has not been corrected.
The failure is dormant, but I am not sure how it affects PCH restore
state.
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address
@ 2001-10-10 7:56 dje
0 siblings, 0 replies; 5+ messages in thread
From: dje @ 2001-10-10 7:56 UTC (permalink / raw)
To: gcc-gnats; +Cc: john
>Number: 4520
>Category: other
>Synopsis: cselib.c hash_rtx incorrectly hashes based on rtx address
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: unassigned
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Oct 10 07:56:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator: dje@watson.ibm.com
>Release: 3.1 (experimental)
>Organization:
>Environment:
powerpc-ibm-aix4.3
>Description:
cselib.c hash_rtx hashes based on the address of a symbol
or label instead of the contents, assuming that a
symbol will be unique and only appear once. Hashing based
on the address of internal GCC data structures can produce
non-deterministic results.
>How-To-Repeat:
>Fix:
Work-around error by not applying ggc_strdup() to symbols
in rs6000.c which covers up the design mistake.
>Release-Note:
>Audit-Trail:
>Unformatted:
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-12-22 7:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-12-21 9:04 other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address bangerth
-- strict thread matches above, loose matches on Subject: below --
2002-12-21 23:06 Geoff Keating
2002-12-21 10:29 bangerth
2002-12-21 10:26 David Edelsohn
2001-10-10 7:56 dje
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).