Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address

Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address

[Geoff Keating]

The following reply was made to PR other/4520; it has been noted by GNATS.

From: Geoff Keating <geoffk@geoffk.org>
To: dje@watson.ibm.com
Cc: bangerth@dealii.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
   john@feith.com, nobody@gcc.gnu.org, gcc-gnats@gcc.gnu.org
Subject: Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address
Date: Sat, 21 Dec 2002 22:56:59 -0800

 > Cc: Geoff Keating <geoffk@geoffk.org>
 > Date: Sat, 21 Dec 2002 13:22:13 -0500
 > From: David Edelsohn <dje@watson.ibm.com>
 > X-OriginalArrivalTime: 21 Dec 2002 18:22:33.0209 (UTC) FILETIME=[EE029E90:01C2A91D]
 > 
 > >>>>> bangerth  writes:
 > 
 > Wolfgang> David, you probably have more insight into these things than
 > Wolfgang> me, but I know that some of these address-hashing things
 > Wolfgang> have been purged. Is this particular report still valid?
 >     
 > 	As far as I can tell, the incorrect hashing of addresses of
 > LABEL_REFS and SYMBOL_REFS in cselib.c:hash_rtx() has not been corrected.
 > The failure is dormant, but I am not sure how it affects PCH restore
 > state. 
 
 cselib.c isn't active when PCH files are saved, so nothing in cselib.c
 affects PCH.
 
 -- 
 - Geoffrey Keating <geoffk@geoffk.org>

Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address

[bangerth]

Synopsis: cselib.c hash_rtx incorrectly hashes based on rtx address

State-Changed-From-To: feedback->open
State-Changed-By: bangerth
State-Changed-When: Sat Dec 21 10:29:40 2002
State-Changed-Why:
    Probably still exists. Thanks for the quick feedback, David!
    
    W.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=4520

Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address

[David Edelsohn]

The following reply was made to PR other/4520; it has been noted by GNATS.

From: David Edelsohn <dje@watson.ibm.com>
To: bangerth@dealii.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
   john@feith.com, nobody@gcc.gnu.org, gcc-gnats@gcc.gnu.org
Cc: Geoff Keating <geoffk@geoffk.org>
Subject: Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address 
Date: Sat, 21 Dec 2002 13:22:13 -0500

 >>>>> bangerth  writes:
 
 Wolfgang> David, you probably have more insight into these things than
 Wolfgang> me, but I know that some of these address-hashing things
 Wolfgang> have been purged. Is this particular report still valid?
     
 	As far as I can tell, the incorrect hashing of addresses of
 LABEL_REFS and SYMBOL_REFS in cselib.c:hash_rtx() has not been corrected.
 The failure is dormant, but I am not sure how it affects PCH restore
 state. 
 
 David

Re: other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address

[bangerth]

Synopsis: cselib.c hash_rtx incorrectly hashes based on rtx address

State-Changed-From-To: open->feedback
State-Changed-By: bangerth
State-Changed-When: Sat Dec 21 09:04:44 2002
State-Changed-Why:
    David, you probably have more insight into these things than
    me, but I know that some of these address-hashing things
    have been purged. Is this particular report still valid?
    
    Thanks
      Wolfgang

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=4520

other/4520: cselib.c hash_rtx incorrectly hashes based on rtx address

[dje]

>Number:         4520
>Category:       other
>Synopsis:       cselib.c hash_rtx incorrectly hashes based on rtx address
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 10 07:56:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     dje@watson.ibm.com
>Release:        3.1 (experimental)
>Organization:
>Environment:
powerpc-ibm-aix4.3
>Description:
cselib.c hash_rtx hashes based on the address of a symbol
or label instead of the contents, assuming that a
symbol will be unique and only appear once.  Hashing based
on the address of internal GCC data structures can produce
non-deterministic results.
>How-To-Repeat:

>Fix:
Work-around error by not applying ggc_strdup() to symbols
in rs6000.c which covers up the design mistake.
>Release-Note:
>Audit-Trail:
>Unformatted: