Re: preprocessor/7312: bootstrap failure due to invalid use of errno

Re: preprocessor/7312: bootstrap failure due to invalid use of errno

[zack]

Synopsis: bootstrap failure due to invalid use of errno

Responsible-Changed-From-To: neil->zack
Responsible-Changed-By: zack
Responsible-Changed-When: Fri May  9 15:26:15 2003
Responsible-Changed-Why:
    Working on a fix.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7312

Re: preprocessor/7312: bootstrap failure due to invalid use of errno

[neil]

Synopsis: bootstrap failure due to invalid use of errno

State-Changed-From-To: open->closed
State-Changed-By: neil
State-Changed-When: Sun May 11 14:56:39 2003
State-Changed-Why:
    Fixed in 3.4.  I'll update 3.3 when it's open.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7312

Re: preprocessor/7312: bootstrap failure due to invalid use of errno

[Zack Weinberg]

The following reply was made to PR preprocessor/7312; it has been noted by GNATS.

From: Zack Weinberg <zack@codesourcery.com>
To: Neil Booth <neil@daikokuya.co.uk>
Cc: Bruno Haible <bruno@clisp.org>,  gcc-bugs@gcc.gnu.org,
	  gcc-gnats@gcc.gnu.org,  gcc-patches@gcc.gnu.org
Subject: Re: preprocessor/7312: bootstrap failure due to invalid use of
 errno
Date: Fri, 09 May 2003 15:24:56 -0700

 Neil Booth <neil@daikokuya.co.uk> writes:
 
 > Bruno Haible wrote:-
 >
 >> Zack Weinberg writes:
 >> > At that point in the code,
 >> > nothing has been done to give errno a meaningful value, so ->err_no
 >> > should just be cleared to 0.
 >> 
 >> Well, I thought (and still think) that 'errno' here means the error
 >> status from cpp_simplify_path. See the comments at the head of the
 >> function cpp_simplify_path.
 >> 
 >> I also think that validate_pch() should not ignore this error status.
 >
 > I agree that Bruno's original patch is the right one.
 
 Would you please check it in, then?  I'm in the middle of a messy
 unrelated project, and not in a position to test stuff.
 
 zw

Re: preprocessor/7312: bootstrap failure due to invalid use of errno

[Neil Booth]

The following reply was made to PR preprocessor/7312; it has been noted by GNATS.

From: Neil Booth <neil@daikokuya.co.uk>
To: Bruno Haible <bruno@clisp.org>
Cc: Zack Weinberg <zack@codesourcery.com>, gcc-bugs@gcc.gnu.org,
	gcc-gnats@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: preprocessor/7312: bootstrap failure due to invalid use of errno
Date: Fri, 9 May 2003 23:09:03 +0100

 Bruno Haible wrote:-
 
 > Zack Weinberg writes:
 > > At that point in the code,
 > > nothing has been done to give errno a meaningful value, so ->err_no
 > > should just be cleared to 0.
 > 
 > Well, I thought (and still think) that 'errno' here means the error
 > status from cpp_simplify_path. See the comments at the head of the
 > function cpp_simplify_path.
 > 
 > I also think that validate_pch() should not ignore this error status.
 
 I agree that Bruno's original patch is the right one.
 
 Neil.

Re: preprocessor/7312: bootstrap failure due to invalid use of errno

[Bruno Haible]

The following reply was made to PR preprocessor/7312; it has been noted by GNATS.

From: Bruno Haible <bruno@clisp.org>
To: Zack Weinberg <zack@codesourcery.com>
Cc: gcc-bugs@gcc.gnu.org, gcc-gnats@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: preprocessor/7312: bootstrap failure due to invalid use of
 errno
Date: Fri, 9 May 2003 18:04:09 +0200 (CEST)

 Zack Weinberg writes:
 > At that point in the code,
 > nothing has been done to give errno a meaningful value, so ->err_no
 > should just be cleared to 0.
 
 Well, I thought (and still think) that 'errno' here means the error
 status from cpp_simplify_path. See the comments at the head of the
 function cpp_simplify_path.
 
 I also think that validate_pch() should not ignore this error status.
 
 Bruno

Re: preprocessor/7312: bootstrap failure due to invalid use of errno

[Zack Weinberg]

The following reply was made to PR preprocessor/7312; it has been noted by GNATS.

From: Zack Weinberg <zack@codesourcery.com>
To: gcc-bugs@gcc.gnu.org, bruno@clisp.org
Cc: gcc-gnats@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: preprocessor/7312: bootstrap failure due to invalid use of
 errno
Date: Fri, 09 May 2003 08:26:33 -0700

 http://gcc.gnu.org/PR?7312
 
 I apologize for not noticing this bug earlier.  It's indeed a bug, but
 I don't think your suggested fix is right.  At that point in the code,
 nothing has been done to give errno a meaningful value, so ->err_no
 should just be cleared to 0.
 
 I will apply this patch later today, along with some other changes, if
 bootstrap succeeds.
 
 zw
 
         PR preprocessor/7312
         * cppfiles.c (find_or_create_entry): Initialize file->err_no
         to 0, not errno.
 
 ===================================================================
 Index: cppfiles.c
 --- cppfiles.c	21 Apr 2003 19:21:53 -0000	1.168
 +++ cppfiles.c	9 May 2003 15:24:48 -0000
 @@ -184,7 +184,7 @@ find_or_create_entry (pfile, fname)
        file = xcnew (struct include_file);
        file->name = name;
        file->header_name = name;
 -      file->err_no = errno;
 +      file->err_no = 0;
        node = splay_tree_insert (pfile->all_include_files,
  				(splay_tree_key) file->name,
  				(splay_tree_value) file);

Re: preprocessor/7312: bootstrap failure due to invalid use of errno

[bangerth]

Synopsis: bootstrap failure due to invalid use of errno

Responsible-Changed-From-To: unassigned->neil
Responsible-Changed-By: bangerth
Responsible-Changed-When: Fri May  9 15:20:35 2003
Responsible-Changed-Why:
    Neil, this file seems to be your pet. There's a patch in
    this PR that seems like relatively low risk (and is small).
    Would you mind taking a look at it?
    
    Thanks
      W.
State-Changed-From-To: feedback->open
State-Changed-By: bangerth
State-Changed-When: Fri May  9 15:20:35 2003
State-Changed-Why:
    .

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7312