public inbox for
help / color / mirror / Atom feed
* [binutils-gdb] Fix ARM_CC_FOR_TARGET handling
@ 2022-06-09 14:36 Pedro Alves
  0 siblings, 0 replies; only message in thread
From: Pedro Alves @ 2022-06-09 14:36 UTC (permalink / raw)
  To: gdb-cvs;h=8db775b211bb01d06197bf6dabb6b32b5428d5e2

commit 8db775b211bb01d06197bf6dabb6b32b5428d5e2
Author: Pedro Alves <>
Date:   Thu Jun 9 15:32:52 2022 +0100

    Fix ARM_CC_FOR_TARGET handling
    The previous patch that introduced the arm_cc_for_target procedure
    moved the ARM_CC_FOR_TARGET global check to that procedure, but forgot
    to tell tcl that ARM_CC_FOR_TARGET is a global.  As a result,
    specifying ARM_CC_FOR_TARGET on the command line actually does
    nothing.  This fixes it.
    Change-Id: I4e33b7633fa665e2f7b8f8c9592a949d74a19153

 gdb/testsuite/lib/gdb.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 67e5838a7a7..37accd9947a 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -8671,12 +8671,12 @@ proc get_set_option_choices {set_cmd} {
 # that the executable they produce can run.
 gdb_caching_proc arm_cc_for_target {
-    if {[info exists ARM_CC_FOR_TARGET]} {
+    if {[info exists ::ARM_CC_FOR_TARGET]} {
 	# If the user specified the compiler explicitly, then don't
 	# check whether the resulting binary runs outside GDB.  Assume
 	# that it does, and if it turns out it doesn't, then the user
 	# should get loud FAILs, instead of UNSUPPORTED.
+	return $::ARM_CC_FOR_TARGET
     # Fallback to a few common compiler names.  Also confirm the

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-09 14:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 14:36 [binutils-gdb] Fix ARM_CC_FOR_TARGET handling Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).