From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: use gdb_test_multiple in gdb_breakpoint
Date: Thu, 5 Jan 2023 11:36:37 -0500 [thread overview]
Message-ID: <01722fc1-e9cc-1372-0e51-db288a036f3f@polymtl.ca> (raw)
In-Reply-To: <fded05f7-cae0-6471-26f6-d34a395f005e@suse.de>
On 1/5/23 11:31, Tom de Vries wrote:
> On 1/5/23 17:28, Simon Marchi wrote:
>> On 1/5/23 04:04, Tom de Vries wrote:
>>> On 1/3/23 20:22, Simon Marchi via Gdb-patches wrote:
>>>> - -re "$gdb_prompt $" {
>>>> - if { $print_fail } {
>>>> - fail $test_name
>>>> - }
>>>> - return 0
>>>> - }
>>>
>>> This caused:
>>> ...
>>> FAIL: gdb.dwarf2/dw2-main-no-line-number.exp: gdb_breakpoint: set breakpoint at 1
>>> FAIL: gdb.dwarf2/dw2-main-no-line-number.exp: !$breakpoint_at_missing_lineno_set
>>> FAIL: gdb.go/methods.exp: going to first breakpoint (the program exited)
>>> FAIL: gdb.go/methods.exp: going to second breakpoint (the program is no longer running)
>>> ...
>>>
>>> Re-inserting this piece of code fixes it.
>>
>> Ah, sorry for this, and thanks for reporting. The CI test job I usually
>> use is a bit broken right now, so I don't test as well as I should.
>
> Ah, that's too bad, I hope you get it running properly again.
>
>> Does the patch below look good?
>>
>
> LGTM, thanks.
>
> - Tom
Thanks, pushed.
Simon
next prev parent reply other threads:[~2023-01-05 16:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 19:22 Simon Marchi
2023-01-04 9:15 ` Lancelot SIX
2023-01-04 16:11 ` Simon Marchi
2023-01-04 16:18 ` Lancelot SIX
2023-01-04 16:22 ` Simon Marchi
2023-01-04 17:40 ` Lancelot SIX
2023-01-04 18:02 ` Lancelot SIX
2023-01-04 19:05 ` Simon Marchi
2023-01-04 19:12 ` Lancelot SIX
2023-01-05 9:04 ` Tom de Vries
2023-01-05 16:28 ` Simon Marchi
2023-01-05 16:31 ` Tom de Vries
2023-01-05 16:36 ` Simon Marchi [this message]
2023-01-10 15:33 ` Pedro Alves
2023-01-10 15:50 ` Simon Marchi
2023-01-10 19:56 ` Pedro Alves
2023-01-10 20:42 ` Simon Marchi
2023-01-11 19:05 ` Pedro Alves
2023-01-11 19:42 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01722fc1-e9cc-1372-0e51-db288a036f3f@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).