From: Lancelot SIX <lsix@lancelotsix.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: use gdb_test_multiple in gdb_breakpoint
Date: Wed, 4 Jan 2023 16:18:44 +0000 [thread overview]
Message-ID: <20230104161817.qbvbspsqcqrjw6w2@ubuntu.lan> (raw)
In-Reply-To: <9b050608-4bb6-dbc3-69f6-ebc9ad2cc303@polymtl.ca>
> Oh, right, I missed that. I folded the test name in the
> gdb_test_multiple call (removed the test_name var) and used
> $gdb_test_name in the fail call. I updated the patch locally. Should I
> add your Reviewed-By after those changes?
>
> Simon
>
Yes, with those change, feel free to add
Reviewed-By: Lancelot Six <lancelot.six@amd.com>
Best,
Lancelot.
next prev parent reply other threads:[~2023-01-04 16:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 19:22 Simon Marchi
2023-01-04 9:15 ` Lancelot SIX
2023-01-04 16:11 ` Simon Marchi
2023-01-04 16:18 ` Lancelot SIX [this message]
2023-01-04 16:22 ` Simon Marchi
2023-01-04 17:40 ` Lancelot SIX
2023-01-04 18:02 ` Lancelot SIX
2023-01-04 19:05 ` Simon Marchi
2023-01-04 19:12 ` Lancelot SIX
2023-01-05 9:04 ` Tom de Vries
2023-01-05 16:28 ` Simon Marchi
2023-01-05 16:31 ` Tom de Vries
2023-01-05 16:36 ` Simon Marchi
2023-01-10 15:33 ` Pedro Alves
2023-01-10 15:50 ` Simon Marchi
2023-01-10 19:56 ` Pedro Alves
2023-01-10 20:42 ` Simon Marchi
2023-01-11 19:05 ` Pedro Alves
2023-01-11 19:42 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104161817.qbvbspsqcqrjw6w2@ubuntu.lan \
--to=lsix@lancelotsix.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).