Re: [PATCH v2 4/4] gdb: testsuite: use gdb_attach to fix jit-elf.exp

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2022-03-17 00:43, Tiezhu Yang wrote:
> If /proc/sys/kernel/yama/ptrace_scope is 1, when execute the following
> command without superuser:
> 
>   make check-gdb TESTS="gdb.base/jit-elf.exp"
> 
> we can see the following messages in gdb/testsuite/gdb.log:
> 
>   (gdb) attach 1650108
>   Attaching to program: /home/yangtiezhu/build/gdb/testsuite/outputs/gdb.base/jit-elf/jit-elf-main, process 1650108
>   ptrace: Operation not permitted.
>   (gdb) FAIL: gdb.base/jit-elf.exp: attach: one_jit_test-2: break here 1: attach
> 
> use gdb_attach to fix the above issue.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>  gdb/testsuite/gdb.base/jit-elf.exp | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.base/jit-elf.exp b/gdb/testsuite/gdb.base/jit-elf.exp
> index 8a4c5b7..61ddb2a 100644
> --- a/gdb/testsuite/gdb.base/jit-elf.exp
> +++ b/gdb/testsuite/gdb.base/jit-elf.exp
> @@ -57,11 +57,10 @@ proc clean_reattach {} {
>  
>      clean_restart ${main_binfile}
>  
> -    set test "attach"
> -    gdb_test_multiple "attach $testpid" "$test" {
> -	-re "Attaching to program.*.*main.*at .*$main_srcfile:.*$gdb_prompt $" {
> -	    pass "$test"
> -	}
> +    if {![gdb_attach $testpid {
> +	"pattern" "main.*at .*$::main_srcfile:.*"
> +    }]} {
> +	return
>      }

I suggest writing it like this, it will be more readable:


    set attach_opts {
	"pattern" "main.*at .*$::main_srcfile:.*"
    }

    if { ![gdb_attach $testpid $attach_opts] } {
	return
    }

I still get some failures when I run with ptrace_scope=1, meaning we are
missing something.  I think that the clean_reattach proc should return a
value to indicate whether it worked, and the callers should return early
as well on failure, all the way up to the top-level of the test.

Simon