public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Cc: Pedro Alves <pedro@palves.net>
Subject: Re: [PATCH v2 2/4] gdb: testsuite: add new gdb_attach to check "attach" command
Date: Thu, 17 Mar 2022 20:29:34 +0800	[thread overview]
Message-ID: <0e917ff5-3fc6-c900-4dfa-87ae665259b4@loongson.cn> (raw)
In-Reply-To: <57079f2f-81d5-2723-867a-73547684ec32@polymtl.ca>



On 03/17/2022 08:02 PM, Simon Marchi wrote:
>
>
> On 2022-03-17 07:51, Simon Marchi via Gdb-patches wrote:
>>
>>
>> On 2022-03-17 00:43, Tiezhu Yang wrote:
>>> This commit adds new gdb_attach to centralize the failure checking of
>>> "attach" command. Return 0 if attach failed, otherwise return 1.
>>>
>>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>>
>> LGTM.
>>
>> Simon
>
> Just a precision, please wait before pushing this until Pedro has time
> to review the series.

OK, thank you, I will send v3 later.

Patch #1 and #3 need to do a little changes, patch #4 need to do some 
more changes as you said:

"I think that the clean_reattach proc should return a
value to indicate whether it worked, and the callers should return early
as well on failure, all the way up to the top-level of the test."

Thanks,
Tiezhu


  reply	other threads:[~2022-03-17 12:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17  4:43 [PATCH v2 0/4] gdb: add gdb_attach to fix failed testcases Tiezhu Yang
2022-03-17  4:43 ` [PATCH v2 1/4] gdb: testsuite: remove attach test from can_spawn_for_attach Tiezhu Yang
2022-03-17 11:50   ` Simon Marchi
2022-03-17  4:43 ` [PATCH v2 2/4] gdb: testsuite: add new gdb_attach to check "attach" command Tiezhu Yang
2022-03-17 11:51   ` Simon Marchi
2022-03-17 12:02     ` Simon Marchi
2022-03-17 12:29       ` Tiezhu Yang [this message]
2022-03-17  4:43 ` [PATCH v2 3/4] gdb: testsuite: use gdb_attach to fix attach-pie-noexec.exp Tiezhu Yang
2022-03-17 11:56   ` Simon Marchi
2022-03-17  4:43 ` [PATCH v2 4/4] gdb: testsuite: use gdb_attach to fix jit-elf.exp Tiezhu Yang
2022-03-17 12:02   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e917ff5-3fc6-c900-4dfa-87ae665259b4@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).