From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tiezhu Yang <yangtiezhu@loongson.cn>, gdb-patches@sourceware.org
Cc: Pedro Alves <pedro@palves.net>
Subject: Re: [PATCH v2 2/4] gdb: testsuite: add new gdb_attach to check "attach" command
Date: Thu, 17 Mar 2022 07:51:32 -0400 [thread overview]
Message-ID: <6f25b237-f869-e4f9-8b11-35abcb6eb5db@polymtl.ca> (raw)
In-Reply-To: <1647492213-21824-3-git-send-email-yangtiezhu@loongson.cn>
On 2022-03-17 00:43, Tiezhu Yang wrote:
> This commit adds new gdb_attach to centralize the failure checking of
> "attach" command. Return 0 if attach failed, otherwise return 1.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
LGTM.
Simon
next prev parent reply other threads:[~2022-03-17 11:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 4:43 [PATCH v2 0/4] gdb: add gdb_attach to fix failed testcases Tiezhu Yang
2022-03-17 4:43 ` [PATCH v2 1/4] gdb: testsuite: remove attach test from can_spawn_for_attach Tiezhu Yang
2022-03-17 11:50 ` Simon Marchi
2022-03-17 4:43 ` [PATCH v2 2/4] gdb: testsuite: add new gdb_attach to check "attach" command Tiezhu Yang
2022-03-17 11:51 ` Simon Marchi [this message]
2022-03-17 12:02 ` Simon Marchi
2022-03-17 12:29 ` Tiezhu Yang
2022-03-17 4:43 ` [PATCH v2 3/4] gdb: testsuite: use gdb_attach to fix attach-pie-noexec.exp Tiezhu Yang
2022-03-17 11:56 ` Simon Marchi
2022-03-17 4:43 ` [PATCH v2 4/4] gdb: testsuite: use gdb_attach to fix jit-elf.exp Tiezhu Yang
2022-03-17 12:02 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f25b237-f869-e4f9-8b11-35abcb6eb5db@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).