Re: [PATCH v5] gdb: add a symbol* argument to get_return_value

[Simon Marchi <simon.marchi@polymtl.ca>]

> diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c
> index 03bd4934506..2298c179ba8 100644
> --- a/gdb/python/py-finishbreakpoint.c
> +++ b/gdb/python/py-finishbreakpoint.c
> @@ -40,13 +40,15 @@ struct finish_breakpoint_object
>  {
>    /* gdb.Breakpoint base class.  */
>    gdbpy_breakpoint_object py_bp;
> -  /* gdb.Type object of the value return by the breakpointed function.
> -     May be NULL if no debug information was available or return type
> -     was VOID.  */
> -  PyObject *return_type;
> -  /* gdb.Value object of the function finished by this breakpoint.  Will be
> -     NULL if return_type is NULL.  */
> +
> +  /* gdb.Symbol object of the function finished by this breakpoint.  */
> +  PyObject *func_symbol;
> +
> +  /* gdb.Value object of the function finished by this breakpoint.
> +
> +     nullptr if no debug information was available or return type was VOID.  */
>    PyObject *function_value;

Actually I would mention the "nullptr if no debug..." part in
func_symbol's documentation as well, since in the code we do check
whether func_symbol is nullptr.

LGTM with that fixed.

And I have a question I didn't bring up before, because I don't want to
increase the scope of this patch, but I am asking just for the sake of
discussing.  Do you know why we wrapped return_type, and now
func_symbol, in Python objects?  Any reason why we don't save the struct
type / struct symbol pointer directly?  To protect against the
underlying object disappearing while the FinishBreakpoint exists, maybe?

Simon