public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <lancelot.six@amd.com>
To: <gdb-patches@sourceware.org>
Cc: <lsix@lancelotsix.com>, Lancelot SIX <lancelot.six@amd.com>
Subject: [PATCH v3 0/2] Make GDB respect the DW_CC_nocall attribute
Date: Wed, 2 Feb 2022 12:41:13 -0600	[thread overview]
Message-ID: <20220202184115.83396-1-lancelot.six@amd.com> (raw)

Hi,

This is a V3 following
https://sourceware.org/pipermail/gdb-patches/2022-January/185563.html.

Noticeable changes since V2:

- Instead of using get_function_name (COREADDR, ...) in order to format
  messages displayed to the user in get_return_value, this series now
  ensures that the function's symbol is passed to get_return_value.
  With the symbol available, getting the function name is a matter of
  calling 'symbol::print_name'.  This overall simplifies the
  implementation.

  To simplify the review process, changes required to have the symbol in
  get_return_value are done in a preparatory patch.

- Fix coding style issues reported by Bruno.

- Remove newline at the end of the testcase.

Thanks to Bruno and Simon for the comments.

Tested on x86_64-linux with no regression observed.

All feedback welcome.

Best,
Lancelot.

Lancelot SIX (2):
  gdb: add a symbol* argument to get_return_value
  gdb: Respect the DW_CC_nocall attribute

 gdb/gdbtypes.c                                | 11 +++
 gdb/gdbtypes.h                                | 10 ++
 gdb/infcall.c                                 |  5 +
 gdb/infcmd.c                                  | 14 ++-
 gdb/inferior.h                                |  3 +-
 gdb/python/py-finishbreakpoint.c              | 29 ++++--
 gdb/stack.c                                   | 18 +++-
 gdb/testsuite/gdb.dwarf2/calling-convention.c | 35 +++++++
 .../gdb.dwarf2/calling-convention.exp         | 97 +++++++++++++++++++
 9 files changed, 207 insertions(+), 15 deletions(-)
 create mode 100644 gdb/testsuite/gdb.dwarf2/calling-convention.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/calling-convention.exp


base-commit: 0d8cbc5f2fcbcb9eb207f12507fdfe04f3d3ae14
-- 
2.25.1


             reply	other threads:[~2022-02-02 18:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-02 18:41 Lancelot SIX [this message]
2022-02-02 18:41 ` [PATCH v3 1/2] gdb: add a symbol* argument to get_return_value Lancelot SIX
2022-02-02 21:01   ` Simon Marchi
2022-02-02 21:59     ` [PATCH v4] " Lancelot SIX
2022-02-03  1:03       ` Simon Marchi
2022-02-03 11:10         ` Six, Lancelot
2022-02-03 12:35           ` Simon Marchi
2022-02-03 15:46         ` Lancelot SIX
2022-02-03 18:28         ` [PATCH v5] " Lancelot SIX
2022-02-03 19:26           ` Simon Marchi
2022-02-03 22:34             ` Six, Lancelot
2022-02-02 18:41 ` [PATCH v3 2/2] gdb: Respect the DW_CC_nocall attribute Lancelot SIX
2022-02-08 14:27   ` Simon Marchi
2022-02-15 10:53     ` Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220202184115.83396-1-lancelot.six@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).