From: Lancelot SIX <lsix@lancelotsix.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Lancelot SIX <lancelot.six@amd.com>,
simark@simark.ca, gdb-patches@sourceware.org
Subject: Re: [PATCH v4] gdb: add a symbol* argument to get_return_value
Date: Thu, 3 Feb 2022 15:46:24 +0000 [thread overview]
Message-ID: <20220203154624.m63nmq3wbenwfis2@Plymouth> (raw)
In-Reply-To: <cef7b867-4474-3499-3684-4de4a07dd7bd@polymtl.ca>
> - struct value *func_value;
> -
> /* Ignore Python errors at this stage. */
> - self_bpfinish->return_type = type_to_type_object (ret_type);
> - PyErr_Clear ();
> - func_value = read_var_value (function, NULL, frame);
> - self_bpfinish->function_value =
> - value_to_value_object (func_value);
> + value *func_value = read_var_value (function, NULL, frame);
> + self_bpfinish->function_value
> + = value_to_value_object (func_value);
> PyErr_Clear ();
> +
> + self_bpfinish->func_symbol
> + = symbol_to_symbol_object (function);
Shouldn’t there be a call to PyErr_Clear () here? (I did forget it initially).
Lancelot
next prev parent reply other threads:[~2022-02-03 15:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 18:41 [PATCH v3 0/2] Make GDB respect the DW_CC_nocall attribute Lancelot SIX
2022-02-02 18:41 ` [PATCH v3 1/2] gdb: add a symbol* argument to get_return_value Lancelot SIX
2022-02-02 21:01 ` Simon Marchi
2022-02-02 21:59 ` [PATCH v4] " Lancelot SIX
2022-02-03 1:03 ` Simon Marchi
2022-02-03 11:10 ` Six, Lancelot
2022-02-03 12:35 ` Simon Marchi
2022-02-03 15:46 ` Lancelot SIX [this message]
2022-02-03 18:28 ` [PATCH v5] " Lancelot SIX
2022-02-03 19:26 ` Simon Marchi
2022-02-03 22:34 ` Six, Lancelot
2022-02-02 18:41 ` [PATCH v3 2/2] gdb: Respect the DW_CC_nocall attribute Lancelot SIX
2022-02-08 14:27 ` Simon Marchi
2022-02-15 10:53 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220203154624.m63nmq3wbenwfis2@Plymouth \
--to=lsix@lancelotsix.com \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=simark@simark.ca \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).