Re: [PATCH v3 1/2] gdb: add a symbol* argument to get_return_value

[Simon Marchi <simark@simark.ca>]

On 2022-02-02 1:41 p.m., Lancelot SIX via Gdb-patches wrote:
> Add an argument to the get_return_value function to indicate the symbol
> of the function the debuggee is returning from.  This will be used by
> the following patch.
> 
> No user visible change after this patch.
> 
> Tested on x86_64-linux.
> 
> Change-Id: Idf1279f1f7199f5022738a6679e0fa63fbd22edc
> ---
>  gdb/infcmd.c                     |  5 +++--
>  gdb/inferior.h                   |  3 ++-
>  gdb/python/py-finishbreakpoint.c | 29 ++++++++++++++++++++---------
>  3 files changed, 25 insertions(+), 12 deletions(-)
> 
> diff --git a/gdb/infcmd.c b/gdb/infcmd.c
> index 994dd5b32a3..66667d67b21 100644
> --- a/gdb/infcmd.c
> +++ b/gdb/infcmd.c
> @@ -1410,7 +1410,8 @@ advance_command (const char *arg, int from_tty)
>     right after an inferior call has finished.  */
>  
>  struct value *
> -get_return_value (struct value *function, struct type *value_type)
> +get_return_value (struct symbol *func_symbol, struct value *function,
> +		  struct type *value_type)

get_return_value's comment (above this) is quite out of date, referring things
that don't exist anymore.  While at it, can you update it, move it to the header
file, and add the /* See ... */ comment here?

Simon