From: Keith Seitz <keiths@redhat.com>
To: Aaron Merey <amerey@redhat.com>
Cc: kevinb@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove download size from debuginfod progress messages
Date: Wed, 23 Mar 2022 11:56:55 -0700 [thread overview]
Message-ID: <098a01ab-6de3-b398-d586-2f4b25260e1f@redhat.com> (raw)
In-Reply-To: <20220323180616.29957-1-amerey@redhat.com>
On 3/23/22 11:06, Aaron Merey wrote:
> On Wed, Mar 23, 2022 at 12:02 PM Keith Seitz <keiths@redhat.com> wrote:
>> On 3/22/22 17:34, Aaron Merey wrote:
>>
>> However, I would really rather not simply remove all download
>> sizes. If we can detect the condition that would print the unhelpful
>> "-0.00 MB", then *just* removing the download size for that case (or
>> printing "unknown" or something) would be my preferred path.
>
> I wanted to keep this patch as simple as possible in order to avoid
> getting bogged down by details that might be more appropriate for
> the patch in-progress that reworks these messages. But I agree that
> we should continue to print sizes if they are available. I've added
> this to the patch below.
I appreciate your patience. I think this is fine, but you will need
to wait for a global maintainer to approve.
Thanks!
Keith
next prev parent reply other threads:[~2022-03-23 18:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 0:34 Aaron Merey
2022-03-23 16:02 ` Keith Seitz
2022-03-23 18:06 ` Aaron Merey
2022-03-23 18:56 ` Keith Seitz [this message]
2022-03-24 15:17 ` Simon Marchi
2022-03-24 19:04 ` Aaron Merey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=098a01ab-6de3-b398-d586-2f4b25260e1f@redhat.com \
--to=keiths@redhat.com \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).