From: Aaron Merey <amerey@redhat.com>
To: Simon Marchi <simark@simark.ca>
Cc: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove download size from debuginfod progress messages
Date: Thu, 24 Mar 2022 15:04:22 -0400 [thread overview]
Message-ID: <CAJDtP-QJqGqGygqVW3hD8PkEpBuXYOQq609x58DqSHKGUL67Bg@mail.gmail.com> (raw)
In-Reply-To: <eabe522a-4126-ce60-0227-9c7ad5892523@simark.ca>
Hi Simon,
On Thu, Mar 24, 2022 at 11:26 AM Simon Marchi <simark@simark.ca> wrote:
> I'm fine with an interim patch, but I'd really like to see the progress
> bar back, I enjoy it :)!
>
> I haven't been involved in those dicussions so I don't know what the
> plan is. But typically progress bars have an "undefined total" mode
> where you can still tell that the operation is progressing (bytes are
> being received), you just don't what percentage of the total.
That is probably what we'll end up doing. The progress bar will return!
> But really, is it a problem for GDB master to print "~0.00 MB", until
> the "real" fix is merged? It's not like it's causing a crash or
> anything like that? Or is it something you want to push to the GDB 12
> branch?
We received a request to fix this issue and thought it would be best
to patch it here first before addressing it downstream.
> The patch LGTM in any case, if that's the route you want to take.
Thanks. Pushed as commit b0e0d830d9.
Aaron
prev parent reply other threads:[~2022-03-24 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 0:34 Aaron Merey
2022-03-23 16:02 ` Keith Seitz
2022-03-23 18:06 ` Aaron Merey
2022-03-23 18:56 ` Keith Seitz
2022-03-24 15:17 ` Simon Marchi
2022-03-24 19:04 ` Aaron Merey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJDtP-QJqGqGygqVW3hD8PkEpBuXYOQq609x58DqSHKGUL67Bg@mail.gmail.com \
--to=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).