public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Aaron Merey <amerey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove download size from debuginfod progress messages
Date: Wed, 23 Mar 2022 09:02:47 -0700	[thread overview]
Message-ID: <5ed305d0-3650-a9f9-e128-22f873cd96a0@redhat.com> (raw)
In-Reply-To: <20220323003432.123142-1-amerey@redhat.com>

On 3/22/22 17:34, Aaron Merey wrote:
> Currently debuginfod progress update messages include the size of
> each download:
> 
>    Downloading 7.5 MB separate debug info /lib/libxyz.so.0
> 
> This value originates from the Content-Length HTTP header of the
> transfer.  However this header is not guaranteed to be present for
> each download.  This can happen when debuginfod servers compress files
> on-the-fly at the time of transfer.  In this case gdb wrongly prints
> "-0.00 MB" as the size.

I realize this is an interim patch to address an issue currently
under development, and I'm okay with that. There are a lot of
people that use devel versions of gdb to do work. [At least I
hope I'm not alone!]

However, I would really rather not simply remove all download
sizes. If we can detect the condition that would print the unhelpful
"-0.00 MB", then *just* removing the download size for that case (or
printing "unknown" or something) would be my preferred path.

YMMV, and I am not a maintainer, etc.

Keith


  reply	other threads:[~2022-03-23 16:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23  0:34 Aaron Merey
2022-03-23 16:02 ` Keith Seitz [this message]
2022-03-23 18:06   ` Aaron Merey
2022-03-23 18:56     ` Keith Seitz
2022-03-24 15:17     ` Simon Marchi
2022-03-24 19:04       ` Aaron Merey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ed305d0-3650-a9f9-e128-22f873cd96a0@redhat.com \
    --to=keiths@redhat.com \
    --cc=amerey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).