public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tromey@adacore.com>
Cc: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Initial implementation of Debugger Adapter Protocol
Date: Wed, 4 Jan 2023 13:27:50 +0100	[thread overview]
Message-ID: <0b6635ea-ee55-1edd-6f4b-149a3ab200f5@suse.de> (raw)
In-Reply-To: <7f2d41d6-ba52-a7da-4144-a252aabd10ea@suse.de>

On 1/4/23 12:59, Tom de Vries via Gdb-patches wrote:
> On 1/3/23 15:14, Tom Tromey wrote:
>> Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c: In member
>> Tom> function ‘virtual void dap_interp::init(bool)’:
>> Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c:83:27: error:
>> Tom> ‘PyObject_CallNoArgs’ was not declared in this scope
>> Tom>    gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ()));
>> Tom>                            ^~~~~~~~~~~~~~~~~~~
>> Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c:83:27: note:
>> Tom> suggested alternative: ‘_PyObject_CallNoArg’
>> Tom>    gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ()));
>> Tom>                            ^~~~~~~~~~~~~~~~~~~
>> Tom>                            _PyObject_CallNoArg
>> Tom> ...
>>
>> Sorry about that.  I'm going to apply the appended, which should fix the
>> problem.
> 
> That fixed the build problem, thanks for that.
> 
> Now I'm running into an error in the testsuite:
> ...
> ERROR: eof reading json header
>      while executing
> "error "eof reading json header""
>      invoked from within
> "expect {
> -i exp19 -timeout 10
>          -re "^Content-Length: (\[0-9\]+)\r\n" {
>              set length $expect_out(1,string)
>              exp_continue
>          }
>          -re "^(\[^\r\n\]+)..."
>      ("uplevel" body line 1)
>      invoked from within
> "uplevel $body" NONE eof reading json header
> UNRESOLVED: gdb.dap/basic-dap.exp: startup - initialize
> ...

Hmm, that seems to be because:
...
(gdb)
#5  0x0000000000a59a7c in gdbpy_handle_exception ()
     at /home/vries/gdb_versions/devel/src/gdb/python/py-utils.c:396
396             error (_("Error occurred in Python: %s"), msg.get ());
(gdb) p msg.get ()
$1 = 0x2b91d10 "module 'queue' has no attribute 'SimpleQueue'"
...

That's new in python 3.7, and I have:
...
$ ldd ./gdb | grep python
         libpython3.6m.so.1.0 => /usr/lib64/libpython3.6m.so.1.0 
(0x00007f93ed624000)
...

Thanks,
- Tom

  reply	other threads:[~2023-01-04 12:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01 16:30 Tom Tromey
2022-09-01 16:38 ` Eli Zaretskii
2022-09-12 19:54 ` Tom Tromey
2022-09-13  2:26   ` Eli Zaretskii
2022-10-06 14:27   ` Tom Tromey
2023-01-02 16:54     ` Tom Tromey
2023-01-03  8:04       ` Tom de Vries
2023-01-03 14:14         ` Tom Tromey
2023-01-04 11:59           ` Tom de Vries
2023-01-04 12:27             ` Tom de Vries [this message]
2023-01-05  9:49               ` [PATCH] [gdb/python] Avoid queue.SimpleQueue for python 3.6 Tom de Vries
2023-01-05 15:19                 ` Tom Tromey
2023-01-05 16:34                   ` Tom de Vries
2023-01-05 17:07                     ` Tom Tromey
2023-01-05 11:35 ` [PATCH] Initial implementation of Debugger Adapter Protocol Tom de Vries
2023-01-05 15:24   ` Tom Tromey
2023-01-05 16:17     ` Tom de Vries
2023-01-06 14:12       ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b6635ea-ee55-1edd-6f4b-149a3ab200f5@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).