Re: [PATCH] Initial implementation of Debugger Adapter Protocol

[Tom de Vries <tdevries@suse.de>]

On 1/5/23 16:24, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> In case you haven't seen it, on IRC someone mentioned:
> 
> I didn't.
> 
> Tom> diff --git a/gdb/python/lib/gdb/dap/io.py b/gdb/python/lib/gdb/dap/io.py
> Tom> index 656ac08b4ec..1d561f07665 100644
> Tom> --- a/gdb/python/lib/gdb/dap/io.py
> Tom> +++ b/gdb/python/lib/gdb/dap/io.py
> Tom> @@ -22,7 +22,7 @@ def read_json(stream):
> Tom>      """Read a JSON-RPC message from STREAM.
> Tom>      The decoded object is returned."""
> Tom>      # First read and parse the header.
> Tom> -    content_length = None
> Tom> +    content_length = 0
> Tom>      while True:
> Tom>          line = stream.readline()
> Tom>          line = line.strip()
> 
> In this case, though, the protocol request is malformed and I think it's
> fine for gdb to just give up.
> 

I see.

> TBH I am not sure what should officially happen for a malformed request.
> I don't think the docs I read address this.

Agreed, I also couldn't find that info.

I suppose we can try to use a more intuitive message for the exception, 
say "malformed DAP request".

Thanks,
- Tom