From: Tom Tromey <tromey@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tromey@adacore.com>,
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Initial implementation of Debugger Adapter Protocol
Date: Tue, 03 Jan 2023 07:14:28 -0700 [thread overview]
Message-ID: <87tu17iu2j.fsf@tromey.com> (raw)
In-Reply-To: <5cd9edba-b1b2-060e-d8d2-98ff6d28a5e7@suse.de> (Tom de Vries's message of "Tue, 3 Jan 2023 09:04:17 +0100")
Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c: In member
Tom> function ‘virtual void dap_interp::init(bool)’:
Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c:83:27: error:
Tom> ‘PyObject_CallNoArgs’ was not declared in this scope
Tom> gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ()));
Tom> ^~~~~~~~~~~~~~~~~~~
Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c:83:27: note:
Tom> suggested alternative: ‘_PyObject_CallNoArg’
Tom> gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ()));
Tom> ^~~~~~~~~~~~~~~~~~~
Tom> _PyObject_CallNoArg
Tom> ...
Sorry about that. I'm going to apply the appended, which should fix the
problem.
Tom
commit 5aea5eca6c873334deb41f996dec255786a6f84d
Author: Tom Tromey <tromey@adacore.com>
Date: Tue Jan 3 07:13:01 2023 -0700
Do not use PyObject_CallNoArgs
PyObject_CallNoArgs was introduced in Python 3.9, so avoid it in favor
of PyObject_CallObject.
diff --git a/gdb/python/py-dap.c b/gdb/python/py-dap.c
index 8e977bc55bb..9c77b2a4f76 100644
--- a/gdb/python/py-dap.c
+++ b/gdb/python/py-dap.c
@@ -1,6 +1,6 @@
/* Python DAP interpreter
- Copyright (C) 2022 Free Software Foundation, Inc.
+ Copyright (C) 2022, 2023 Free Software Foundation, Inc.
This file is part of GDB.
@@ -80,7 +80,7 @@ dap_interp::init (bool top_level)
if (func == nullptr)
gdbpy_handle_exception ();
- gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ()));
+ gdbpy_ref<> result_obj (PyObject_CallObject (func.get (), nullptr));
if (result_obj == nullptr)
gdbpy_handle_exception ();
next prev parent reply other threads:[~2023-01-03 14:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 16:30 Tom Tromey
2022-09-01 16:38 ` Eli Zaretskii
2022-09-12 19:54 ` Tom Tromey
2022-09-13 2:26 ` Eli Zaretskii
2022-10-06 14:27 ` Tom Tromey
2023-01-02 16:54 ` Tom Tromey
2023-01-03 8:04 ` Tom de Vries
2023-01-03 14:14 ` Tom Tromey [this message]
2023-01-04 11:59 ` Tom de Vries
2023-01-04 12:27 ` Tom de Vries
2023-01-05 9:49 ` [PATCH] [gdb/python] Avoid queue.SimpleQueue for python 3.6 Tom de Vries
2023-01-05 15:19 ` Tom Tromey
2023-01-05 16:34 ` Tom de Vries
2023-01-05 17:07 ` Tom Tromey
2023-01-05 11:35 ` [PATCH] Initial implementation of Debugger Adapter Protocol Tom de Vries
2023-01-05 15:24 ` Tom Tromey
2023-01-05 16:17 ` Tom de Vries
2023-01-06 14:12 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu17iu2j.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).