Re: [PATCH] gdb::array_view slicing/container selftest - test std::array too (Re: [PATCH v2 2/2] Improve gdb::array_view ctor from contiguous containers)

[Pedro Alves <pedro@palves.net>]

On 2021-11-09 21:58, Lancelot SIX wrote:
> On Tue, Nov 09, 2021 at 05:52:20PM +0000, Pedro Alves wrote:

>> Thanks.  Looking again, I noticed we don't exercise construction from std::array containers,
>> unlike other tests.  This adds it.  WDYT?
> 
> Hi,
> 
> Actually my first version used a fixed size std::array exactly as you
> have here.  I went for a std::vector instead in the version I have
> submitted to the list so I still test against one of the standard
> containers while not having to define StdArray1.
> 
> I am absolutely fine including a test with a std::array. It could even
> replace the std::vector based test since this test is the only one that
> uses this container (in which case the '#include <vector>' line could
> also be dropped).
> 
> In the end, both options check that the old erroneous behavior that
> used to allow slicing now fails to compile. This is the most important
> point.

The main advantage that I was thinking is that testing more than one
standard container here ensures that we're not baking in some assumption
in the interface (now and forever) that only holds true for std::vector.

I'll merge the patch.

Thanks,
Pedro Alves