From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Lancelot SIX <lsix@lancelotsix.com>,
Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH 2/2] Improve gdb::array_view ctor from contiguous containers
Date: Tue, 02 Nov 2021 08:10:10 -0600 [thread overview]
Message-ID: <8735oemywt.fsf@tromey.com> (raw)
In-Reply-To: <0edd9c95-f4d8-2034-6fd6-70ec8a03c255@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Fri, 29 Oct 2021 22:09:01 -0400")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>> Tested by rebuilding using GCC-10.3.0 on GNU/Linux.
Simon> The template part is beyond my understanding, but the explanation makes
Simon> total sense. Let's leave a bit of time for others that understand this
Simon> more to respond, but if you don't hear anything in ~1 week, then go
Simon> ahead and push it.
I think it looks good.
Thanks.
Tom
next prev parent reply other threads:[~2021-11-02 14:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 20:05 [PATCH 0/2] Improve constraints on gdb::array_view::array_view Lancelot SIX
2021-10-20 20:05 ` [PATCH 1/2] Add a const version of gdb_argv:as_array_view Lancelot SIX
2021-10-30 2:03 ` Simon Marchi
2021-10-20 20:05 ` [PATCH 2/2] Improve gdb::array_view ctor from contiguous containers Lancelot SIX
2021-10-30 2:09 ` Simon Marchi
2021-11-02 14:10 ` Tom Tromey [this message]
2021-11-02 16:00 ` Pedro Alves
2021-11-02 22:51 ` Lancelot SIX
2021-11-03 22:20 ` [PATCH v2 " Lancelot SIX
2021-11-04 13:04 ` Pedro Alves
2021-11-08 23:02 ` Lancelot SIX
2021-11-09 17:52 ` [PATCH] gdb::array_view slicing/container selftest - test std::array too (Re: [PATCH v2 2/2] Improve gdb::array_view ctor from contiguous containers) Pedro Alves
2021-11-09 21:58 ` Lancelot SIX
2021-11-09 22:48 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735oemywt.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).