From: Pedro Alves <pedro@palves.net>
To: Lancelot SIX <lsix@lancelotsix.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/2] Improve gdb::array_view ctor from contiguous containers
Date: Thu, 4 Nov 2021 13:04:23 +0000 [thread overview]
Message-ID: <df0d8b58-adf6-6d4d-65bf-313192d6db4b@palves.net> (raw)
In-Reply-To: <20211103222015.50988-1-lsix@lancelotsix.com>
On 2021-11-03 22:20, Lancelot SIX wrote:
> +/* Check that there is no slicing when build a view from a contiguous
> + container. */
> +
The sentence is slightly ungrammatical.
I guess that with "when build a view", you meant either:
-> "when building a view", or,
-> "when we build a view"
Alternatively, you could mirror the comment from the built-in array tests:
/* Check that there's no container->view conversion for containers of derived
types or subclasses. */
In any case, this is OK. Thanks for fixing this!
next prev parent reply other threads:[~2021-11-04 13:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 20:05 [PATCH 0/2] Improve constraints on gdb::array_view::array_view Lancelot SIX
2021-10-20 20:05 ` [PATCH 1/2] Add a const version of gdb_argv:as_array_view Lancelot SIX
2021-10-30 2:03 ` Simon Marchi
2021-10-20 20:05 ` [PATCH 2/2] Improve gdb::array_view ctor from contiguous containers Lancelot SIX
2021-10-30 2:09 ` Simon Marchi
2021-11-02 14:10 ` Tom Tromey
2021-11-02 16:00 ` Pedro Alves
2021-11-02 22:51 ` Lancelot SIX
2021-11-03 22:20 ` [PATCH v2 " Lancelot SIX
2021-11-04 13:04 ` Pedro Alves [this message]
2021-11-08 23:02 ` Lancelot SIX
2021-11-09 17:52 ` [PATCH] gdb::array_view slicing/container selftest - test std::array too (Re: [PATCH v2 2/2] Improve gdb::array_view ctor from contiguous containers) Pedro Alves
2021-11-09 21:58 ` Lancelot SIX
2021-11-09 22:48 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df0d8b58-adf6-6d4d-65bf-313192d6db4b@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).