Re: [PATCH 1/2] Add a const version of gdb_argv:as_array_view

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2021-10-20 16:05, Lancelot SIX via Gdb-patches wrote:
> This commit adds a const versions for the gdb_argv::get and the
> gdb_argv::as_array_view methods.  Those methods will be used in the
> following patch.
> ---
>  gdb/utils.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/gdb/utils.h b/gdb/utils.h
> index f05e6627dca..6f3a70213a4 100644
> --- a/gdb/utils.h
> +++ b/gdb/utils.h
> @@ -195,6 +195,11 @@ class gdb_argv
>      return m_argv;
>    }
>  
> +  const char * const * get () const
> +  {
> +    return m_argv;
> +  }
> +
>    /* Return the underlying array, transferring ownership to the
>       caller.  */
>  
> @@ -227,6 +232,11 @@ class gdb_argv
>      return gdb::array_view<char *> (this->get (), this->count ());
>    }
>  
> +  gdb::array_view<const char * const> as_array_view () const
> +  {
> +    return gdb::array_view<const char * const> (this->get (), this->count ());
> +  }
> +
>    /* Append arguments to this array.  */
>    void append (gdb_argv &&other)
>    {
> 

It might not be the goal of this particular patch, but operator[] could
also gain a const version.  And then many callers could be constified,
from:

  gdb_argv argv (args);

to

  const gdb_argv argv (args);

But the patch LGTM as-is, that's more for future work.

Simon