Re: [PING] [PATCH] gdb: Remove duplicate "gdb Summary" in the test output

Re: [PING] [PATCH] gdb: Remove duplicate "gdb Summary" in the test output

[Tiezhu Yang]

Hi,

Any comments for this patch?
Are you OK with this change?

[PATCH] gdb: Remove duplicate "gdb Summary" in the test output
https://sourceware.org/pipermail/gdb-patches/2022-June/190335.html

It seems that this issue is introduced by commit e83907ff5ffb ("Include 
count of unexpected core files in gdb.sum summary").

Thanks,
Tiezhu

Re: [PING] [PATCH] gdb: Remove duplicate "gdb Summary" in the test output

[Pedro Alves]

On 2022-07-06 1:52 a.m., Tiezhu Yang wrote:
> Hi,
> 
> Any comments for this patch?
> Are you OK with this change?
> 
> [PATCH] gdb: Remove duplicate "gdb Summary" in the test output
> https://sourceware.org/pipermail/gdb-patches/2022-June/190335.html
> 
> It seems that this issue is introduced by commit e83907ff5ffb ("Include count of unexpected core files in gdb.sum summary").

We can't really just remove the printing the tail gdb.sum, as that would
lose the printing of unexpected core files.  The commit log of e83907ff5ffb explains:

                                                              (...) In the
    end, I settled on the script approach for serial mode too, which
    requires making the "check-single" rule print the tail end of the
    gdb.sum file, with a side effect being that if you look at the
    terminal after a run (instead of at the gdb.sum file), you'll see the
    "gdb Summary" section twice, once without the unexpected core lines
    printed, and then another with.  IMO, this isn't an issue; when
    testing in parallel mode, if you look at the terminal after "make -jN
    check", you'll also see multiple "gdb Summary" sections printed.
    
If people find this confusing, one idea would be to print some separator, like
below.  We'd print it in both serial and parallel modes.

(... snip ...)
                === gdb Summary ===

# of expected passes            115
/home/pedro/rocm/gdb/build/gdb/gdb version  13.0.50.20220706-git -nw -nx -iex "set height 0" -iex "set width 0" -data-directory /home/pedro/rocm/gdb/build/gdb/testsuite/../data-directory 

------------------ Final results ------------------

                === gdb Summary ===

# of expected passes            115
/home/pedro/rocm/gdb/build/gdb/gdb version  13.0.50.20220706-git -nw -nx -iex "set height 0" -iex "set width 0" -data-directory /home/pedro/rocm/gdb/build/gdb/testsuite/../data-directory 

make[2]: Leaving directory '/home/pedro/rocm/gdb/build/gdb/testsuite'
make[1]: Leaving directory '/home/pedro/rocm/gdb/build/gdb/testsuite'