* Re: [PING] [PATCH] gdb: Remove duplicate "gdb Summary" in the test output
@ 2022-07-06 0:52 Tiezhu Yang
2022-07-06 19:47 ` Pedro Alves
0 siblings, 1 reply; 2+ messages in thread
From: Tiezhu Yang @ 2022-07-06 0:52 UTC (permalink / raw)
To: gdb-patches; +Cc: Pedro Alves
Hi,
Any comments for this patch?
Are you OK with this change?
[PATCH] gdb: Remove duplicate "gdb Summary" in the test output
https://sourceware.org/pipermail/gdb-patches/2022-June/190335.html
It seems that this issue is introduced by commit e83907ff5ffb ("Include
count of unexpected core files in gdb.sum summary").
Thanks,
Tiezhu
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PING] [PATCH] gdb: Remove duplicate "gdb Summary" in the test output
2022-07-06 0:52 [PING] [PATCH] gdb: Remove duplicate "gdb Summary" in the test output Tiezhu Yang
@ 2022-07-06 19:47 ` Pedro Alves
0 siblings, 0 replies; 2+ messages in thread
From: Pedro Alves @ 2022-07-06 19:47 UTC (permalink / raw)
To: Tiezhu Yang, gdb-patches
On 2022-07-06 1:52 a.m., Tiezhu Yang wrote:
> Hi,
>
> Any comments for this patch?
> Are you OK with this change?
>
> [PATCH] gdb: Remove duplicate "gdb Summary" in the test output
> https://sourceware.org/pipermail/gdb-patches/2022-June/190335.html
>
> It seems that this issue is introduced by commit e83907ff5ffb ("Include count of unexpected core files in gdb.sum summary").
We can't really just remove the printing the tail gdb.sum, as that would
lose the printing of unexpected core files. The commit log of e83907ff5ffb explains:
(...) In the
end, I settled on the script approach for serial mode too, which
requires making the "check-single" rule print the tail end of the
gdb.sum file, with a side effect being that if you look at the
terminal after a run (instead of at the gdb.sum file), you'll see the
"gdb Summary" section twice, once without the unexpected core lines
printed, and then another with. IMO, this isn't an issue; when
testing in parallel mode, if you look at the terminal after "make -jN
check", you'll also see multiple "gdb Summary" sections printed.
If people find this confusing, one idea would be to print some separator, like
below. We'd print it in both serial and parallel modes.
(... snip ...)
=== gdb Summary ===
# of expected passes 115
/home/pedro/rocm/gdb/build/gdb/gdb version 13.0.50.20220706-git -nw -nx -iex "set height 0" -iex "set width 0" -data-directory /home/pedro/rocm/gdb/build/gdb/testsuite/../data-directory
------------------ Final results ------------------
=== gdb Summary ===
# of expected passes 115
/home/pedro/rocm/gdb/build/gdb/gdb version 13.0.50.20220706-git -nw -nx -iex "set height 0" -iex "set width 0" -data-directory /home/pedro/rocm/gdb/build/gdb/testsuite/../data-directory
make[2]: Leaving directory '/home/pedro/rocm/gdb/build/gdb/testsuite'
make[1]: Leaving directory '/home/pedro/rocm/gdb/build/gdb/testsuite'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-06 19:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 0:52 [PING] [PATCH] gdb: Remove duplicate "gdb Summary" in the test output Tiezhu Yang
2022-07-06 19:47 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).