public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Christina Schimpe <christina.schimpe@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/3] Apply fixme notes for multi-target support
Date: Thu, 13 Jan 2022 16:21:15 +0100	[thread overview]
Message-ID: <20220113152118.1465255-1-christina.schimpe@intel.com> (raw)

Hi all, 

this is a set of patches that apply the fixme notes described in commit 5b6d1e4
"Multi-target support".

"You'll notice that remote.c includes some FIXME notes.  These refer to
the fact that the global arrays that hold data for the remote packets
supported are still globals.  For example, if we connect to two
different servers/stubs, then each might support different remote
protocol features.  They might even be different architectures, like
e.g., one ARM baremetal stub, and a x86 gdbserver, to debug a
host/controller scenario as a single program.  That isn't going to
work correctly today, because of said globals.  I'm leaving fixing
that for another pass, since it does not appear to be trivial, and I'd
rather land the base work first.  It's already useful to be able to
debug multiple instances of the same server (e.g., a distributed
cluster, where you have full control over the servers installed), so I
think as is it's already reasonable incremental progress."

Due to the global array and variables used by all remote targets, the command
line configuration for remote targets' features before this set of patches
affected existing remote targets and future remote targets.  It was not
possible to individually configure a remote target's feature.
This behavior is now different.  With this patch series, the currently selected
remote target's as well as a future remote target's feature set can be
configured, without affecting the feature sets of the existing remote targets.

Any feedback about this series of patches is appreciated.

Regards,
Christina

Christina Schimpe (3):
  gdb: Make global feature array a per-remote target array
  gdb: Add per-remote target variables for memory read and write config
  gdb: Remove workaround for the vCont packet

 gdb/remote.c                                  | 1004 +++++++++--------
 gdb/testsuite/gdb.base/remote.exp             |    7 +-
 .../gdb.multi/multi-target-info-inferiors.exp |    6 +-
 gdb/testsuite/gdb.multi/multi-target.exp.tcl  |    7 +-
 4 files changed, 570 insertions(+), 454 deletions(-)

-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


             reply	other threads:[~2022-01-13 15:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 15:21 Christina Schimpe [this message]
2022-01-13 15:21 ` [PATCH 1/3] gdb: Make global feature array a per-remote target array Christina Schimpe
2022-01-14 19:30   ` Tom Tromey
2022-01-20 16:32     ` Schimpe, Christina
2022-01-18 11:30   ` Andrew Burgess
2022-01-20 17:24     ` Schimpe, Christina
2022-01-13 15:21 ` [PATCH 2/3] gdb: Add per-remote target variables for memory read and write config Christina Schimpe
2022-01-14 19:33   ` Tom Tromey
2022-01-18 11:39   ` Andrew Burgess
2022-01-24 15:06     ` Schimpe, Christina
2022-02-04 18:03       ` Andrew Burgess
2022-01-13 15:21 ` [PATCH 3/3] gdb: Remove workaround for the vCont packet Christina Schimpe
2022-01-14 19:42   ` Tom Tromey
2022-01-28 13:28     ` Schimpe, Christina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220113152118.1465255-1-christina.schimpe@intel.com \
    --to=christina.schimpe@intel.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).