RE: [PATCH 1/3] gdb: Make global feature array a per-remote target array

["Schimpe, Christina" <christina.schimpe@intel.com>]

Thank you for the review.

> >> +  int remote_multi_process_p (remote_state *rs) const;
> >> +  int remote_fork_event_p (remote_state*) const;
> >> +  int remote_vfork_event_p (remote_state*) const;
> >> +  int remote_exec_event_p (remote_state*) const;
> 
> It seems like these methods don't actually need the 'remote_state *'
> parameter.
> 
> >> +  void reset_all_packet_configs_support (void);
> 
> New code shouldn't use "(void)", just "()" is fine.  Also, normally if
> we touch a function definition or declaration, we'll also remove a
> 'void' if there is one.

Yes, I agree. I will remove it.

> The packet number can be passed in using the 'context' attached to the
> command.  See cmd_list_element::set_context and
> cmd_list_element::context.
> This is simple to do and would remove the need for this loop.
> 
> It's mildly annoying that this only accepts a pointer and not a scalar,
> but it can either be cast or you could pass the address the slot in
> remote_protocol_packets and then do some pointer math to reconstruct the
> index.
> 
> The same applies to the 'show' command.

Ah, thanks for the hint. I will use the 'context' and remove the loop.

Regards,
Christina
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928