RE: [PATCH 1/3] gdb: Make global feature array a per-remote target array

["Schimpe, Christina" <christina.schimpe@intel.com>]

Thanks for the feedback.

> Could you update your examples to not use implicit values here
> please.  This just makes reading these that little bit harder for no
> reason.

Yes, you are right. I will update this.
 
> However, I do think there are some things we could do to make it clear
> what's going on, I think that the string printed for 'show remote
> PACKET-NAME' should be updated to reflect what it's showing, as in:
> 
>   (gdb) show remote kill-packet
>   Support for the `vKill' packet on the current remote target, is "auto"
> (currently unknown).
> 
> OR
> 
>   (gdb) show remote kill-packet
>   Support for the `vKill' packet on newly created remote targets, is "auto".
> 
> Notice, I dropped the 'currently unknown' as that makes no sense when
> talking about the future targets.
> 
> I also think we should have the set command print something to tell
> the user what changed, so they can know if they messed up, maybe:
> 
>  (gdb) set remote kill-packet off
>  Use of the 'vKill' packet for the current, and future remote targets, set to
> "off".
> 
> OR
> 
>  (gdb) set remote kill-packet off
>  Use of the 'vKill' packet for future remote targets, set to "off".

Yes, that makes sense to me. I will adapt the set/show command prints,
as well as all the tests using the set/show commands. 

> 
> This change absolutely needs a NEWS entry and also a documentation
> update.
> 
> With one exception the rest of my feedback is basically: there should
> be more comments added.  I know that sucks, especially when working in
> older files like remote.c, where the initial code is poorly commented
> anyway, but for me good comments do help understand what the intention
> of a field or struct is, so I think, when we change stuff, we should
> take the opportunity to document what's going on.  So...

I also agree with the rest of your comments and will send a V2 for this soon.

Thanks,
Christina

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928