public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Tom Tromey <tromey@adacore.com>
Cc: Ulrich Weigand <ulrich.weigand@de.ibm.com>,
	Andreas Arnez <arnez@linux.ibm.com>,
	Andrew Burgess <aburgess@redhat.com>,
	Pedro Alves <pedro@palves.net>,
	gdb-patches@sourceware.org, Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH 1/5] gdb.perf/: Fix tcl_string_list_to_python_list {x}
Date: Thu, 26 May 2022 00:37:07 +0200	[thread overview]
Message-ID: <20220525223711.845475-2-iii@linux.ibm.com> (raw)
In-Reply-To: <20220525223711.845475-1-iii@linux.ibm.com>

tcl_string_list_to_python_list {x} returns "(x)", which is not a tuple
(the valid tuple syntax would be "(x,)").  Instead of special-casing
this, just change the function to return what its name says: lists.
This way in the problematic case we will get "[x]".
---
 gdb/testsuite/lib/perftest.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/perftest.exp b/gdb/testsuite/lib/perftest.exp
index bf4eb45bba5..0df4ff15864 100644
--- a/gdb/testsuite/lib/perftest.exp
+++ b/gdb/testsuite/lib/perftest.exp
@@ -159,7 +159,7 @@ proc tcl_string_list_to_python_list { l } {
     foreach elm $l {
 	lappend quoted_list [quote $elm]
     }
-    return "([join $quoted_list {, }])"
+    return "\[[join $quoted_list {, }]\]"
 }
 
 # Helper routine for PerfTest::assemble "run" step implementations.
-- 
2.35.3


  reply	other threads:[~2022-05-25 22:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 22:37 [PATCH 0/5] gdb.perf/: Add JIT performance test Ilya Leoshkevich
2022-05-25 22:37 ` Ilya Leoshkevich [this message]
2022-05-26 14:39   ` [PATCH 1/5] gdb.perf/: Fix tcl_string_list_to_python_list {x} Andrew Burgess
2022-05-25 22:37 ` [PATCH 2/5] gdb.perf/: Add binary_link_with_shlibs setting to GenPerfTest Ilya Leoshkevich
2022-05-26 15:38   ` Andrew Burgess
2022-05-25 22:37 ` [PATCH 3/5] gdb.perf/: Compile the binary with -DSHLIB Ilya Leoshkevich
2022-05-26 15:43   ` Andrew Burgess
2022-05-25 22:37 ` [PATCH 4/5] gdb.base/: Introduce jit-protocol-util.h Ilya Leoshkevich
2022-05-26 15:55   ` Andrew Burgess
2022-05-25 22:37 ` [PATCH 5/5] gdb.perf/: Add JIT performance test Ilya Leoshkevich
2022-05-27 13:32   ` Andrew Burgess
2022-05-27  9:43 ` [PATCH 0/5] " Andrew Burgess
2022-05-30 12:32   ` Ilya Leoshkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220525223711.845475-2-iii@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=aburgess@redhat.com \
    --cc=arnez@linux.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    --cc=tromey@adacore.com \
    --cc=ulrich.weigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).