Re: [PATCH 0/5] gdb.perf/: Add JIT performance test

[Andrew Burgess <aburgess@redhat.com>]

Ilya Leoshkevich <iii@linux.ibm.com> writes:

> Hi,
>
> This series implements a JIT performance test as discussed in [1].
> Patch 1 is a small fix, patches 2-4 are preparations and patch 5 is
> the test itself.
>
> The test can be used as follows:
>
> $ make build-perf -j"$(nproc)" RUNTESTFLAGS=jit.exp
> $ make check-perf RUNTESTFLAGS=jit-check.exp GDB_PERFTEST_MODE=run
>
> The results can be converted to gnuplot-friendly format as follows:
>
> $ perl -ne 'if (/:register_times:(\d+) (.+)/) { print "$1 $2\n"; }' \
>       <gdb.perf/outputs/jit/pieces/perftest.sum >jit.txt
>
> I've uploaded the results to [2].  They are somewhat different from
> those from Andrew, but they still show that [1] is an improvement.

I'm sure the reason for this difference is down to something I did
differently (wrong?) in my original benchmark, but I think it would be
really good to understand what that mistake was, as the performance
characteristics between my benchmark and yours are quite different.

I am taking a look at this myself, but it would be great if you could
run my original benchmark and let me know if you see result similar to
mine, or more similar to your benchmark.

If you can quickly spot why my benchmark does so much better (when
patched) then I'd love to hear why!

Thanks,
Andrew




> The third result shown on the chart is from [3] - with it I can
> pass the 10k JITed objects mark and finally debug CoreCLR JIT with
> GDB.  It's still WIP though - the testsuite shows a couple of
> failures.
>
> Best regards,
> Ilya
>
> [1] https://sourceware.org/pipermail/gdb-patches/2022-May/189341.html
> [2] https://github.com/iii-i/binutils-gdb/blob/section-map-20220525-2/gdb/testsuite/jit.png
> [3] https://github.com/iii-i/binutils-gdb/commits/section-map-20220525-2
>
> Ilya Leoshkevich (5):
>   gdb.perf/: Fix tcl_string_list_to_python_list {x}
>   gdb.perf/: Add binary_link_with_shlibs setting to GenPerfTest
>   gdb.perf/: Compile the binary with -DSHLIB
>   gdb.base/: Introduce jit-protocol-util.h
>   gdb.perf/: Add JIT performance test
>
>  gdb/testsuite/gdb.base/jit-elf-fork-main.c | 37 +---------
>  gdb/testsuite/gdb.base/jit-elf-main.c      | 37 +---------
>  gdb/testsuite/gdb.base/jit-protocol-util.h | 74 +++++++++++++++++++
>  gdb/testsuite/gdb.base/jit-reader-host.c   |  8 +-
>  gdb/testsuite/gdb.perf/jit-check.exp       | 25 +++++++
>  gdb/testsuite/gdb.perf/jit-check.py        | 60 +++++++++++++++
>  gdb/testsuite/gdb.perf/jit-solib.c         | 28 +++++++
>  gdb/testsuite/gdb.perf/jit.c               | 85 ++++++++++++++++++++++
>  gdb/testsuite/gdb.perf/jit.exp             | 37 ++++++++++
>  gdb/testsuite/lib/gen-perf-test.exp        | 25 ++++---
>  gdb/testsuite/lib/perftest.exp             |  2 +-
>  11 files changed, 336 insertions(+), 82 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.base/jit-protocol-util.h
>  create mode 100644 gdb/testsuite/gdb.perf/jit-check.exp
>  create mode 100644 gdb/testsuite/gdb.perf/jit-check.py
>  create mode 100644 gdb/testsuite/gdb.perf/jit-solib.c
>  create mode 100644 gdb/testsuite/gdb.perf/jit.c
>  create mode 100644 gdb/testsuite/gdb.perf/jit.exp
>
> -- 
> 2.35.3