Re: [PATCH 1/5] gdb.perf/: Fix tcl_string_list_to_python_list {x}

[Andrew Burgess <aburgess@redhat.com>]

Ilya Leoshkevich via Gdb-patches <gdb-patches@sourceware.org> writes:

> tcl_string_list_to_python_list {x} returns "(x)", which is not a tuple
> (the valid tuple syntax would be "(x,)").  Instead of special-casing
> this, just change the function to return what its name says: lists.
> This way in the problematic case we will get "[x]".

LGTM.

Thanks,
Andrew


> ---
>  gdb/testsuite/lib/perftest.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/lib/perftest.exp b/gdb/testsuite/lib/perftest.exp
> index bf4eb45bba5..0df4ff15864 100644
> --- a/gdb/testsuite/lib/perftest.exp
> +++ b/gdb/testsuite/lib/perftest.exp
> @@ -159,7 +159,7 @@ proc tcl_string_list_to_python_list { l } {
>      foreach elm $l {
>  	lappend quoted_list [quote $elm]
>      }
> -    return "([join $quoted_list {, }])"
> +    return "\[[join $quoted_list {, }]\]"
>  }
>  
>  # Helper routine for PerfTest::assemble "run" step implementations.
> -- 
> 2.35.3