From: Andrew Burgess <aburgess@redhat.com>
To: Ilya Leoshkevich via Gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tromey@adacore.com>
Cc: Ilya Leoshkevich <iii@linux.ibm.com>,
Pedro Alves <pedro@palves.net>,
Ulrich Weigand <ulrich.weigand@de.ibm.com>,
Andreas Arnez <arnez@linux.ibm.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] gdb.perf/: Compile the binary with -DSHLIB
Date: Thu, 26 May 2022 16:43:45 +0100 [thread overview]
Message-ID: <87v8tsguz2.fsf@redhat.com> (raw)
In-Reply-To: <20220525223711.845475-4-iii@linux.ibm.com>
Ilya Leoshkevich via Gdb-patches <gdb-patches@sourceware.org> writes:
> Performance tests that dynamically load shared libraries may need to
> know their number. Pass it via the preprocessor define.
> ---
> gdb/testsuite/lib/gen-perf-test.exp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/lib/gen-perf-test.exp b/gdb/testsuite/lib/gen-perf-test.exp
> index f0bfdc9317d..8c5413eaa19 100644
> --- a/gdb/testsuite/lib/gen-perf-test.exp
> +++ b/gdb/testsuite/lib/gen-perf-test.exp
> @@ -1321,7 +1321,8 @@ namespace eval GenPerfTest {
> set input_files [_make_binary_input_file_names self $static $run_nr]
> set extra_headers [_get_param $self(binary_extra_headers) $run_nr]
> set binary_file [_make_binary_name self $run_nr]
> - set compile_options [_compile_options self]
> + set nr_gen_shlibs [_get_param $self(nr_gen_shlibs) $run_nr]
> + set compile_options "[_compile_options self] additional_flags=-DSHLIB=$nr_gen_shlibs"
I wonder if we should use a different name to avoid any chance of
confusion with the SHLIB define that is passed when compiling a shared
library? We use the same name, but they have subtly different
meanings...
I'd propose something like TOTAL_NR_SHLIBS or something similar.
Thanks,
Andrew
> set shlib_options [_make_shlib_options self $static $run_nr]
> if { [llength $shlib_options] > 0 } {
> append compile_options " " $shlib_options
> --
> 2.35.3
next prev parent reply other threads:[~2022-05-26 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 22:37 [PATCH 0/5] gdb.perf/: Add JIT performance test Ilya Leoshkevich
2022-05-25 22:37 ` [PATCH 1/5] gdb.perf/: Fix tcl_string_list_to_python_list {x} Ilya Leoshkevich
2022-05-26 14:39 ` Andrew Burgess
2022-05-25 22:37 ` [PATCH 2/5] gdb.perf/: Add binary_link_with_shlibs setting to GenPerfTest Ilya Leoshkevich
2022-05-26 15:38 ` Andrew Burgess
2022-05-25 22:37 ` [PATCH 3/5] gdb.perf/: Compile the binary with -DSHLIB Ilya Leoshkevich
2022-05-26 15:43 ` Andrew Burgess [this message]
2022-05-25 22:37 ` [PATCH 4/5] gdb.base/: Introduce jit-protocol-util.h Ilya Leoshkevich
2022-05-26 15:55 ` Andrew Burgess
2022-05-25 22:37 ` [PATCH 5/5] gdb.perf/: Add JIT performance test Ilya Leoshkevich
2022-05-27 13:32 ` Andrew Burgess
2022-05-27 9:43 ` [PATCH 0/5] " Andrew Burgess
2022-05-30 12:32 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8tsguz2.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=arnez@linux.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=iii@linux.ibm.com \
--cc=pedro@palves.net \
--cc=tromey@adacore.com \
--cc=ulrich.weigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).