* [pushed] [gdb/testsuite] Fix untested in gdb.base/frame-view.exp
@ 2023-01-23 7:59 Tom de Vries
2023-01-23 16:12 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Tom de Vries @ 2023-01-23 7:59 UTC (permalink / raw)
To: gdb-patches
When running test-case gdb.base/frame-view.exp, I see:
...
gdb compile failed, ld: frame-view0.o: in function `main':
frame-view.c:73: undefined reference to `pthread_create'
ld: frame-view.c:76: undefined reference to `pthread_join'
collect2: error: ld returned 1 exit status
UNTESTED: gdb.base/frame-view.exp: failed to prepare
...
Fix this by adding pthreads to the compilation flags.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.base/frame-view.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/frame-view.exp b/gdb/testsuite/gdb.base/frame-view.exp
index edae16735ab..72955bd1aff 100644
--- a/gdb/testsuite/gdb.base/frame-view.exp
+++ b/gdb/testsuite/gdb.base/frame-view.exp
@@ -18,7 +18,7 @@
standard_testfile
if { [build_executable "failed to prepare" \
- ${testfile} ${srcfile}] } {
+ ${testfile} ${srcfile} {debug pthreads}] } {
return
}
base-commit: 7e538762c2c1f2e5c4be31b9ec7d99cc4fbabf7f
--
2.35.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pushed] [gdb/testsuite] Fix untested in gdb.base/frame-view.exp
2023-01-23 7:59 [pushed] [gdb/testsuite] Fix untested in gdb.base/frame-view.exp Tom de Vries
@ 2023-01-23 16:12 ` Simon Marchi
2023-01-23 16:29 ` Tom de Vries
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2023-01-23 16:12 UTC (permalink / raw)
To: Tom de Vries, gdb-patches
On 1/23/23 02:59, Tom de Vries via Gdb-patches wrote:
> When running test-case gdb.base/frame-view.exp, I see:
> ...
> gdb compile failed, ld: frame-view0.o: in function `main':
> frame-view.c:73: undefined reference to `pthread_create'
> ld: frame-view.c:76: undefined reference to `pthread_join'
> collect2: error: ld returned 1 exit status
> UNTESTED: gdb.base/frame-view.exp: failed to prepare
> ...
>
> Fix this by adding pthreads to the compilation flags.
Thanks for fixing this. I suppose it worked on my machines because they
use newer glibcs where pthread is integrated into libc?
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pushed] [gdb/testsuite] Fix untested in gdb.base/frame-view.exp
2023-01-23 16:12 ` Simon Marchi
@ 2023-01-23 16:29 ` Tom de Vries
0 siblings, 0 replies; 3+ messages in thread
From: Tom de Vries @ 2023-01-23 16:29 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
On 1/23/23 17:12, Simon Marchi wrote:
>
>
> On 1/23/23 02:59, Tom de Vries via Gdb-patches wrote:
>> When running test-case gdb.base/frame-view.exp, I see:
>> ...
>> gdb compile failed, ld: frame-view0.o: in function `main':
>> frame-view.c:73: undefined reference to `pthread_create'
>> ld: frame-view.c:76: undefined reference to `pthread_join'
>> collect2: error: ld returned 1 exit status
>> UNTESTED: gdb.base/frame-view.exp: failed to prepare
>> ...
>>
>> Fix this by adding pthreads to the compilation flags.
>
> Thanks for fixing this. I suppose it worked on my machines because they
> use newer glibcs where pthread is integrated into libc?
Np, and ack, that's also what I suppose what happened.
Thanks,
- Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-23 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 7:59 [pushed] [gdb/testsuite] Fix untested in gdb.base/frame-view.exp Tom de Vries
2023-01-23 16:12 ` Simon Marchi
2023-01-23 16:29 ` Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).