From: Simon Farre <simon.farre.cx@gmail.com>
To: gdb-patches@sourceware.org
Cc: tom@tromey.com, aburgess@redhat.com,
Simon Farre <simon.farre.cx@gmail.com>
Subject: [PATCH v2] gdb/dap - Add support for additional target types
Date: Tue, 20 Jun 2023 12:00:17 +0200 [thread overview]
Message-ID: <20230620100017.229708-1-simon.farre.cx@gmail.com> (raw)
After discussion with Tom and Andrew we decided that the best approach
is the simple one - make the "target" field contain a string that
performs the desired command.
So for instance "extended-remote 127.0.0.1:50505" or "remote foohost"
etc.
---
gdb/python/lib/gdb/dap/launch.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/python/lib/gdb/dap/launch.py b/gdb/python/lib/gdb/dap/launch.py
index c3c09bc3dd0..7eae8a1916c 100644
--- a/gdb/python/lib/gdb/dap/launch.py
+++ b/gdb/python/lib/gdb/dap/launch.py
@@ -74,7 +74,7 @@ def attach(*, pid: Optional[int] = None, target: Optional[str] = None, **args):
if pid is not None:
cmd = "attach " + str(pid)
elif target is not None:
- cmd = "target remote " + target
+ cmd = "target " + target
else:
raise Exception("attach requires either 'pid' or 'target'")
# Use send_gdb_with_response to ensure we get an error if the
--
2.40.1
next reply other threads:[~2023-06-20 10:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 10:00 Simon Farre [this message]
2023-06-20 14:02 ` Tom Tromey
-- strict thread matches above, loose matches on Subject: below --
2023-06-13 12:06 Simon Farre
2023-06-13 18:32 ` Tom Tromey
2023-06-14 10:54 ` Simon Farre
2023-06-14 11:56 ` Andrew Burgess
2023-06-14 12:01 ` Simon Farre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620100017.229708-1-simon.farre.cx@gmail.com \
--to=simon.farre.cx@gmail.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).