Re: [PATCH v2] gdb/dap - Add support for additional target types

[Andrew Burgess <aburgess@redhat.com>]

Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:

>> I don't really understand this part of the implementation.
>>
>> However, I was wondering if we really want to bother with all this.
>> Perhaps instead we should just have the clients pass any old "target"
>> argument as a string and have gdb invoke '"target " + client_string'.
>> I guess I don't see a whole lot of value in trying to separate out the
>> various parameters somehow.
>
> I think you're right actually. I looked over the other `target` commands 
> and it seems as though they all
>
> take just 1 parameter, which makes this implementation 
> superfluous/over-designed. I think the
>
> simple string approach, where the user passes `remote <addr>` or 
> `extended-remote <addr>` is better.

I know this change was focused on remote/extended-remote, but just to
backup what Tom is suggesting, 'target sim' takes an arbitrary set of
options, which can vary depending on which simulator is being invoked,
there's no one single set of arguments.  Thus just passing any argument
string through from Python to GDB will be best for that target.

Thanks,
Andrew