Re: [PATCH v2] gdb/dap - Add support for additional target types

[Tom Tromey <tromey@adacore.com>]

>>>>> "Simon" == Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> Adds support for extended-remote configuration. Initial work
Simon> was really just adding 2-3 lines that checked for extended-remote
Simon> but I figured this design makes it trivial to add the remaining target
Simon> types and this design also is self-documenting.

Extensions are documented in the manual, so this should patch that as
well.

Simon> +# To add targets in the future: add required parameters set to their type
Simon> +target_type_requirements = {}
Simon> +target_type_requirements["remote"] = {"address"}
Simon> +target_type_requirements["extended-remote"] = {"address"}

I don't really understand this part of the implementation.

However, I was wondering if we really want to bother with all this.
Perhaps instead we should just have the clients pass any old "target"
argument as a string and have gdb invoke '"target " + client_string'.
I guess I don't see a whole lot of value in trying to separate out the
various parameters somehow.

Simon> +@request("attach")
Simon> +def attach(
Simon> +    *,
Simon> +    pid: Optional[int] = None,
Simon> +    target: Optional[dict] = None,
Simon> +    **args
Simon> +):
Simon> +    # Ensure configurationDone does not try to run (in launch.py)
Simon> +    global _program
Simon> +    _program = None

I don't think this will work properly.
However if we go with the "simple string" approach then the code would
be as simple, or simpler, and could just remain where it is.

Tom