From: Simon Farre <simon.farre.cx@gmail.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb/dap - Add support for additional target types
Date: Wed, 14 Jun 2023 12:54:37 +0200 [thread overview]
Message-ID: <2f1611d0-58d9-93ac-e442-eabdb9fdd1ae@gmail.com> (raw)
In-Reply-To: <87a5x35i25.fsf@tromey.com>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
> I don't really understand this part of the implementation.
>
> However, I was wondering if we really want to bother with all this.
> Perhaps instead we should just have the clients pass any old "target"
> argument as a string and have gdb invoke '"target " + client_string'.
> I guess I don't see a whole lot of value in trying to separate out the
> various parameters somehow.
I think you're right actually. I looked over the other `target` commands
and it seems as though they all
take just 1 parameter, which makes this implementation
superfluous/over-designed. I think the
simple string approach, where the user passes `remote <addr>` or
`extended-remote <addr>` is better.
next prev parent reply other threads:[~2023-06-14 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 12:06 Simon Farre
2023-06-13 18:32 ` Tom Tromey
2023-06-14 10:54 ` Simon Farre [this message]
2023-06-14 11:56 ` Andrew Burgess
2023-06-14 12:01 ` Simon Farre
2023-06-20 10:00 Simon Farre
2023-06-20 14:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f1611d0-58d9-93ac-e442-eabdb9fdd1ae@gmail.com \
--to=simon.farre.cx@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).