* [PATCH] Remove declaration of re_comp
@ 2023-11-12 23:41 Tom Tromey
2023-11-13 1:57 ` Kevin Buettner
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-11-12 23:41 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
defs.h declares re_comp, but it shouldn't. If this is needed, it
should be picked up from xregex.h via gdb_regex.h.
Tested by rebuilding.
---
gdb/defs.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/gdb/defs.h b/gdb/defs.h
index b8612e1ac6d..e6dd93e791e 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -299,12 +299,6 @@ extern std::string relocate_gdb_directory (const char *initial, bool relocatable
extern int annotation_level; /* in stack.c */
\f
-/* From regex.c or libc. BSD 4.4 declares this with the argument type as
- "const char *" in unistd.h, so we can't declare the argument
- as "char *". */
-
-extern "C" char *re_comp (const char *);
-
/* From symfile.c */
extern void symbol_file_command (const char *, int);
--
2.41.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove declaration of re_comp
2023-11-12 23:41 [PATCH] Remove declaration of re_comp Tom Tromey
@ 2023-11-13 1:57 ` Kevin Buettner
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Buettner @ 2023-11-13 1:57 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On Sun, 12 Nov 2023 16:41:42 -0700
Tom Tromey <tom@tromey.com> wrote:
> defs.h declares re_comp, but it shouldn't. If this is needed, it
> should be picked up from xregex.h via gdb_regex.h.
LGTM.
Reviewed-by: Kevin Buettner <kevinb@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-13 1:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-12 23:41 [PATCH] Remove declaration of re_comp Tom Tromey
2023-11-13 1:57 ` Kevin Buettner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).