From: Kevin Buettner <kevinb@redhat.com>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Cc: gdb-patches@sourceware.org, Luis Machado <luis.machado@arm.com>
Subject: Re: [PATCH v3 1/2] gdb/testsuite: Add libc_has_debug_info require helper
Date: Tue, 23 Apr 2024 10:09:47 -0700 [thread overview]
Message-ID: <20240423100947.3d5692be@f39-zbm-amd> (raw)
In-Reply-To: <20240422230700.1173173-2-thiago.bauermann@linaro.org>
On Mon, 22 Apr 2024 20:06:59 -0300
Thiago Jung Bauermann <thiago.bauermann@linaro.org> wrote:
> Factor the test for libc debug info out of gdb.base/relativedebug.exp to
> a new procedure.
>
> Also, change the "info sharedlibrary" test to explicitly detect when
> libc has debug info.
> ---
>
> As mentioned in the cover letter, the new testcase doesn't use this helper
> procedure anymore so this is an optional patch. I think it's a nice
> cleanup, though I didn't find any other testcase that need it so perhaps
> the new helper is not as useful as I imagine it to be. I'm fine with not
> committing this patch.
>
> Changes in v3:
> - Include <stdio.h> in test program to avoid error when using clang
> (suggested by Kevin).
I agree that it's a nice cleanup and I think that it should go in.
I've retested with CC_FOR_TARGET set to clang and also gcc. It works
for both.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2024-04-23 17:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 23:06 [PATCH v3 0/2] Add testcase for libc memory operations Thiago Jung Bauermann
2024-04-22 23:06 ` [PATCH v3 1/2] gdb/testsuite: Add libc_has_debug_info require helper Thiago Jung Bauermann
2024-04-23 17:09 ` Kevin Buettner [this message]
2024-04-24 16:25 ` Thiago Jung Bauermann
2024-04-25 19:39 ` Bernd Edlinger
2024-04-26 3:00 ` Thiago Jung Bauermann
2024-04-26 5:06 ` Bernd Edlinger
2024-04-26 16:35 ` Pedro Alves
2024-04-26 17:18 ` Thiago Jung Bauermann
2024-04-30 1:57 ` Thiago Jung Bauermann
2024-04-22 23:07 ` [PATCH v3 2/2] gdb/testsuite: Add gdb.base/memops-watchpoint.exp Thiago Jung Bauermann
2024-04-23 17:52 ` Kevin Buettner
2024-04-24 17:05 ` Thiago Jung Bauermann
2024-04-24 23:22 ` Kevin Buettner
2024-04-26 1:42 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423100947.3d5692be@f39-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).