From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 1/2] gdb/testsuite: Add libc_has_debug_info require helper
Date: Thu, 25 Apr 2024 21:39:14 +0200 [thread overview]
Message-ID: <fb462789-0d3b-4254-94f7-d197efeee7df@hotmail.de> (raw)
In-Reply-To: <87h6fq3ezg.fsf@linaro.org>
Hi Thiago,
On 4/24/24 18:25, Thiago Jung Bauermann wrote:
>
> Hello Kevin,
>
> Kevin Buettner <kevinb@redhat.com> writes:
>
>> On Mon, 22 Apr 2024 20:06:59 -0300
>> Thiago Jung Bauermann <thiago.bauermann@linaro.org> wrote:
>>
>>> Factor the test for libc debug info out of gdb.base/relativedebug.exp to
>>> a new procedure.
>>>
>>> Also, change the "info sharedlibrary" test to explicitly detect when
>>> libc has debug info.
>>> ---
>>>
>>> As mentioned in the cover letter, the new testcase doesn't use this helper
>>> procedure anymore so this is an optional patch. I think it's a nice
>>> cleanup, though I didn't find any other testcase that need it so perhaps
>>> the new helper is not as useful as I imagine it to be. I'm fine with not
>>> committing this patch.
>>>
>>> Changes in v3:
>>> - Include <stdio.h> in test program to avoid error when using clang
>>> (suggested by Kevin).
>>
>> I agree that it's a nice cleanup and I think that it should go in.
>>
>> I've retested with CC_FOR_TARGET set to clang and also gcc. It works
>> for both.
>>
>> Approved-by: Kevin Buettner <kevinb@redhat.com>
>
> Thank you! Pushed as commit f5ef12c3f1af.
>
I think I have an issue with this commmit.
I use a self-built riscv-unknown-elf toolchain with newlib,
so there is no libc at all, regardless of debug info.
since today, I see messages like:
Running /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp ...
FAIL: gdb.base/relativedebug.exp: info sharedlibrary libc.so
ERROR: tcl error sourcing /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp.
ERROR: tcl error code TCL READ VARNAME
ERROR: can't read "libc_has_debug_info": no such variable
while executing
"verbose "$me: returning $libc_has_debug_info" 2"
(procedure "gdb_real__libc_has_debug_info" line 47)
invoked from within
"gdb_real__libc_has_debug_info"
("uplevel" body line 1)
invoked from within
"uplevel 2 [list $real_name {*}$args]"
invoked from within
"gdb_do_cache_wrap $real_name {*}$args"
(procedure "gdb_do_cache" line 48)
invoked from within
"gdb_do_cache libc_has_debug_info"
(procedure "libc_has_debug_info" line 1)
invoked from within
"libc_has_debug_info"
("uplevel" body line 1)
invoked from within
"uplevel 1 $fn"
(procedure "require" line 11)
invoked from within
"require {!target_info exists gdb,nosignals} libc_has_debug_info"
(file "/home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp" line 16)
invoked from within
"source /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp"
("uplevel" body line 1)
invoked from within
"uplevel #0 source /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp"
invoked from within
"catch "uplevel #0 source $test_file_name" msg"
UNRESOLVED: gdb.base/relativedebug.exp: testcase '/home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp' aborted due to Tcl error
PATH: gdb.base/relativedebug.exp: testcase '/home/ed/gnu/
while previously that looked like:
gdb compile failed, /home/ed/gnu/riscv64-unknown-elf/lib/gcc/riscv64-unknown-elf/14.0.1/../../../../riscv64-unknown-elf/bin/ld: /tmp/ccjr19GC.o: in function `main':
/home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.c:30:(.text+0x28): undefined reference to `alarm'
/home/ed/gnu/riscv64-unknown-elf/lib/gcc/riscv64-unknown-elf/14.0.1/../../../../riscv64-unknown-elf/bin/ld: /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.c:31:(.text+0x30): undefined reference to `pause'
/home/ed/gnu/riscv64-unknown-elf/lib/gcc/riscv64-unknown-elf/14.0.1/../../../../riscv64-unknown-elf/bin/ld: /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.c:31:(.text+0x38): undefined reference to `pause'
collect2: error: ld returned 1 exit status
UNTESTED: gdb.base/relativedebug.exp: failed to compile
so not very noisy, newlib does apparently not have alarm, pause, sleep, and similar,
but much easier to understand the output...
Regards,
Bernd.
next prev parent reply other threads:[~2024-04-25 19:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 23:06 [PATCH v3 0/2] Add testcase for libc memory operations Thiago Jung Bauermann
2024-04-22 23:06 ` [PATCH v3 1/2] gdb/testsuite: Add libc_has_debug_info require helper Thiago Jung Bauermann
2024-04-23 17:09 ` Kevin Buettner
2024-04-24 16:25 ` Thiago Jung Bauermann
2024-04-25 19:39 ` Bernd Edlinger [this message]
2024-04-26 3:00 ` Thiago Jung Bauermann
2024-04-26 5:06 ` Bernd Edlinger
2024-04-26 16:35 ` Pedro Alves
2024-04-26 17:18 ` Thiago Jung Bauermann
2024-04-30 1:57 ` Thiago Jung Bauermann
2024-04-22 23:07 ` [PATCH v3 2/2] gdb/testsuite: Add gdb.base/memops-watchpoint.exp Thiago Jung Bauermann
2024-04-23 17:52 ` Kevin Buettner
2024-04-24 17:05 ` Thiago Jung Bauermann
2024-04-24 23:22 ` Kevin Buettner
2024-04-26 1:42 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb462789-0d3b-4254-94f7-d197efeee7df@hotmail.de \
--to=bernd.edlinger@hotmail.de \
--cc=gdb-patches@sourceware.org \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).