Re: [PATCH v3 1/2] gdb/testsuite: Add libc_has_debug_info require helper

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Hello Kevin,

Kevin Buettner <kevinb@redhat.com> writes:

> On Mon, 22 Apr 2024 20:06:59 -0300
> Thiago Jung Bauermann <thiago.bauermann@linaro.org> wrote:
>
>> Factor the test for libc debug info out of gdb.base/relativedebug.exp to
>> a new procedure.
>> 
>> Also, change the "info sharedlibrary" test to explicitly detect when
>> libc has debug info.
>> ---
>> 
>> As mentioned in the cover letter, the new testcase doesn't use this helper
>> procedure anymore so this is an optional patch.  I think it's a nice
>> cleanup, though I didn't find any other testcase that need it so perhaps
>> the new helper is not as useful as I imagine it to be. I'm fine with not
>> committing this patch.
>> 
>> Changes in v3:
>> - Include <stdio.h> in test program to avoid error when using clang
>>   (suggested by Kevin).
>
> I agree that it's a nice cleanup and I think that it should go in.
>
> I've retested with CC_FOR_TARGET set to clang and also gcc.  It works
> for both.
>
> Approved-by: Kevin Buettner <kevinb@redhat.com>

Thank you! Pushed as commit f5ef12c3f1af.

-- 
Thiago