From: Pedro Alves <pedro@palves.net>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] gdb: don't print global thread-id to CLI in describe_other_breakpoints
Date: Wed, 8 Feb 2023 17:55:03 +0000 [thread overview]
Message-ID: <3696851d-d3a2-e18a-6108-0a945f6a56ae@palves.net> (raw)
In-Reply-To: <a3b98e8303607fdfb3bdb521736701e8f0b3dba6.1675869497.git.aburgess@redhat.com>
On 2023-02-08 3:23 p.m., Andrew Burgess via Gdb-patches wrote:
> I noticed that describe_other_breakpoints was printing the global
> thread-id to the CLI. For CLI output we should be printing the
> inferior local thread-id (e.g. "2.1"). This can be seen in the
> following GDB session:
>
> (gdb) info threads
> Id Target Id Frame
> 1.1 Thread 4065742.4065742 "bp-thread-speci" main () at /tmp/bp-thread-specific.c:27
> * 2.1 Thread 4065743.4065743 "bp-thread-speci" main () at /tmp/bp-thread-specific.c:27
> (gdb) break foo thread 2.1
> Breakpoint 3 at 0x40110a: foo. (2 locations)
> (gdb) break foo thread 1.1
> Note: breakpoint 3 (thread 2) also set at pc 0x40110a.
> Note: breakpoint 3 (thread 2) also set at pc 0x40110a.
> Breakpoint 4 at 0x40110a: foo. (2 locations)
>
> Notice that GDB says:
>
> Note: breakpoint 3 (thread 2) also set at pc 0x40110a.
>
> The 'thread 2' in here is using the global thread-id, we should
> instead say 'thread 2.1' which corresponds to how the user specified
> the breakpoint.
>
> This commit fixes this issue and adds a test.
Approved-By: Pedro Alves <pedro@palves.net>
next prev parent reply other threads:[~2023-02-08 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 15:23 [PATCH 0/3] Avoid printing global thread-id in CLI command output Andrew Burgess
2023-02-08 15:23 ` [PATCH 1/3] gdb: don't print global thread-id to CLI in describe_other_breakpoints Andrew Burgess
2023-02-08 17:55 ` Pedro Alves [this message]
2023-02-11 17:41 ` Andrew Burgess
2023-02-08 15:23 ` [PATCH 2/3] gdb: show task number " Andrew Burgess
2023-02-08 17:55 ` Pedro Alves
2023-02-11 17:42 ` Andrew Burgess
2023-02-08 15:23 ` [PATCH 3/3] gdb: don't use the global thread-id in the saved breakpoints file Andrew Burgess
2023-02-08 17:55 ` Pedro Alves
2023-02-10 19:22 ` Andrew Burgess
2023-02-17 17:49 ` Pedro Alves
2023-02-27 19:45 ` Andrew Burgess
2023-03-16 17:06 ` Andrew Burgess
2023-03-17 18:01 ` Pedro Alves
2023-03-20 10:38 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3696851d-d3a2-e18a-6108-0a945f6a56ae@palves.net \
--to=pedro@palves.net \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).