Re: [PATCH 3/3] gdb: don't use the global thread-id in the saved breakpoints file

[Andrew Burgess <aburgess@redhat.com>]

Pedro Alves <pedro@palves.net> writes:

> On 2023-02-08 3:23 p.m., Andrew Burgess via Gdb-patches wrote:
>
>>  breakpoint::print_recreate_thread (struct ui_file *fp) const
>>  {
>>    if (thread != -1)
>> -    gdb_printf (fp, " thread %d", thread);
>> +    {
>> +      struct thread_info *thr = find_thread_global_id (thread);
>> +      gdb_printf (fp, " thread %s", print_thread_id (thr));
>
> print_thread_id only prints the inferior-qualified thread id if
> there are multiple inferiors.  I am wondering whether the save breakpoints
> file should _always_ end up with inferior-qualified thread ids, so that
> reloading the saved file works the same if you meanwhile add another
> inferior.

As a counter argument; if the user has a single inferior and places
breakpoints on a particular thread, we'll have a save like:

  break foo thread 2

Then if the user sets up two inferiors, they can select which inferior
the breakpoints should apply to - source the saves from inferior 2, and
the b/p will apply to inferior 2 threads, source from inferior 1, and
the b/p will apply to inferior 1 threads.

If the user has changed the inferior setup when sourcing the breakpoint
save file, I think they have to take some responsibility for knowing
what they want ... maybe?

If you feel strongly then it's easy enough to print the qualified
thread-id, just let me know and I'll get it done.

Thanks,
Andrew

>
> Otherwise,
>
>  Approved-By: Pedro Alves <pedro@palves.net>