From: Pedro Alves <pedro@palves.net>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] gdb: don't use the global thread-id in the saved breakpoints file
Date: Wed, 8 Feb 2023 17:55:15 +0000 [thread overview]
Message-ID: <22df7afc-cf88-d260-516d-7b9a45e2ad78@palves.net> (raw)
In-Reply-To: <be46fe0bc0e6658400ff50d36290d5c5ccc7e2dd.1675869497.git.aburgess@redhat.com>
On 2023-02-08 3:23 p.m., Andrew Burgess via Gdb-patches wrote:
> breakpoint::print_recreate_thread (struct ui_file *fp) const
> {
> if (thread != -1)
> - gdb_printf (fp, " thread %d", thread);
> + {
> + struct thread_info *thr = find_thread_global_id (thread);
> + gdb_printf (fp, " thread %s", print_thread_id (thr));
print_thread_id only prints the inferior-qualified thread id if
there are multiple inferiors. I am wondering whether the save breakpoints
file should _always_ end up with inferior-qualified thread ids, so that
reloading the saved file works the same if you meanwhile add another inferior.
Otherwise,
Approved-By: Pedro Alves <pedro@palves.net>
next prev parent reply other threads:[~2023-02-08 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 15:23 [PATCH 0/3] Avoid printing global thread-id in CLI command output Andrew Burgess
2023-02-08 15:23 ` [PATCH 1/3] gdb: don't print global thread-id to CLI in describe_other_breakpoints Andrew Burgess
2023-02-08 17:55 ` Pedro Alves
2023-02-11 17:41 ` Andrew Burgess
2023-02-08 15:23 ` [PATCH 2/3] gdb: show task number " Andrew Burgess
2023-02-08 17:55 ` Pedro Alves
2023-02-11 17:42 ` Andrew Burgess
2023-02-08 15:23 ` [PATCH 3/3] gdb: don't use the global thread-id in the saved breakpoints file Andrew Burgess
2023-02-08 17:55 ` Pedro Alves [this message]
2023-02-10 19:22 ` Andrew Burgess
2023-02-17 17:49 ` Pedro Alves
2023-02-27 19:45 ` Andrew Burgess
2023-03-16 17:06 ` Andrew Burgess
2023-03-17 18:01 ` Pedro Alves
2023-03-20 10:38 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22df7afc-cf88-d260-516d-7b9a45e2ad78@palves.net \
--to=pedro@palves.net \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).