public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] gdb: show task number in describe_other_breakpoints
Date: Wed, 8 Feb 2023 17:55:11 +0000	[thread overview]
Message-ID: <eb56a977-4f03-238b-065f-703fad4635cf@palves.net> (raw)
In-Reply-To: <8716dc72011765a13c3eee0b60a262fbcbd48d41.1675869497.git.aburgess@redhat.com>

On 2023-02-08 3:23 p.m., Andrew Burgess via Gdb-patches wrote:

>  # Now, insert a breakpoint that should stop only if task 3 stops, and
> -# extract its number.
> -gdb_breakpoint "break_me task 3" message
> -set bp_number [get_integer_valueof "\$bpnum" -1]
> -if {$bp_number < 0} {
> -    return
> -}
> +# extract its number.  Use gdb_test here so that we can validate that
> +# the 'Breakpoint ... also set at' line correctly includes the task
> +# number of the prevoius breakpoint.

prevoius -> previous

Otherwise,
 
 Approved-By: Pedro Alves <pedro@palves.net>

Thanks,
Pedro Alves

> +gdb_test "break break_me task 3" \
> +    [multi_line \
> +	 "Note: breakpoint $bp_number \\(task 1\\) also set at pc $hex\\." \
> +	 "Breakpoint $decimal at $hex: \[^\r\n\]+"]
> +set bp_number [get_integer_valueof "\$bpnum" "INVALID" \
> +		   "get number of breakpoint for task 3"]
>  gdb_test "info breakpoints" "foo.adb:${decimal}\r\n\\s+stop only in task 3" \
>      "check info breakpoints for task 3 breakpoint"
>  
> 


  reply	other threads:[~2023-02-08 17:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 15:23 [PATCH 0/3] Avoid printing global thread-id in CLI command output Andrew Burgess
2023-02-08 15:23 ` [PATCH 1/3] gdb: don't print global thread-id to CLI in describe_other_breakpoints Andrew Burgess
2023-02-08 17:55   ` Pedro Alves
2023-02-11 17:41     ` Andrew Burgess
2023-02-08 15:23 ` [PATCH 2/3] gdb: show task number " Andrew Burgess
2023-02-08 17:55   ` Pedro Alves [this message]
2023-02-11 17:42     ` Andrew Burgess
2023-02-08 15:23 ` [PATCH 3/3] gdb: don't use the global thread-id in the saved breakpoints file Andrew Burgess
2023-02-08 17:55   ` Pedro Alves
2023-02-10 19:22     ` Andrew Burgess
2023-02-17 17:49       ` Pedro Alves
2023-02-27 19:45         ` Andrew Burgess
2023-03-16 17:06           ` Andrew Burgess
2023-03-17 18:01             ` Pedro Alves
2023-03-20 10:38               ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb56a977-4f03-238b-065f-703fad4635cf@palves.net \
    --to=pedro@palves.net \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).