From: Luis Machado <luis.machado@arm.com>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/6] [gdb/aarch64] sme2: Enable SME2 for AArch64 gdb on Linux
Date: Wed, 30 Aug 2023 13:53:31 +0100 [thread overview]
Message-ID: <39105c1a-6922-61c4-c615-357b82b6325c@arm.com> (raw)
In-Reply-To: <87o7itl1xi.fsf@linaro.org>
On 8/27/23 02:16, Thiago Jung Bauermann wrote:
>
> Hello Luis,
>
> I have only one minor nit about this patch. In any case:
>
> Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
>
> Luis Machado <luis.machado@arm.com> writes:
>
>> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
>> index d7fcef5a0db..edbe6895c86 100644
>> --- a/gdb/aarch64-linux-nat.c
>> +++ b/gdb/aarch64-linux-nat.c
>> @@ -376,6 +376,37 @@ store_za_to_thread (struct regcache *regcache)
>> tdep->sme_svcr_regnum);
>> }
>>
>> +/* Fill GDB's REGCACHE with the ZT register set contents from the
>> + current thread. If there is no active ZA register state, make the
>> + ZT register contents zero. */
>
> Same comment about "current thread" from the SME patch series: the
> function uses the regcache's ptid to identify the thread, so it's not
> from the current thread that it gets the register values.
>
>> +static void
>> +fetch_zt_from_thread (struct regcache *regcache)
>> +{
>> + aarch64_gdbarch_tdep *tdep
>> + = gdbarch_tdep<aarch64_gdbarch_tdep> (regcache->arch ());
>> +
>> + /* Read ZT state from the thread to the register cache. */
>> + aarch64_zt_regs_copy_to_reg_buf (regcache->ptid ().lwp (),
>> + regcache,
>> + tdep->sme2_zt0_regnum);
>> +}
>> +
>> +/* Store the NT_ARM_ZT register set contents from GDB's REGCACHE to the current
>> + thread. */
>
> Also here.
>
Thanks. Fixed now.
>> +
>> +static void
>> +store_zt_to_thread (struct regcache *regcache)
>> +{
>> + aarch64_gdbarch_tdep *tdep
>> + = gdbarch_tdep<aarch64_gdbarch_tdep> (regcache->arch ());
>> +
>> + /* Write ZT state from the register cache to the thread. */
>> + aarch64_zt_regs_copy_from_reg_buf (regcache->ptid ().lwp (),
>> + regcache,
>> + tdep->sme2_zt0_regnum);
>> +}
>
next prev parent reply other threads:[~2023-08-30 12:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 11:21 [PATCH v2 0/6] SME2 support for AArch64 gdb/gdbserver " Luis Machado
2023-08-22 11:21 ` [PATCH v2 1/6] [gdb/aarch64] sme2: Enable SME2 for AArch64 gdb " Luis Machado
2023-08-27 1:16 ` Thiago Jung Bauermann
2023-08-30 12:53 ` Luis Machado [this message]
2023-08-22 11:21 ` [PATCH v2 2/6] [gdbserver/aarch64] sme2: Enable SME2 support in gdbserver Luis Machado
2023-08-27 1:18 ` Thiago Jung Bauermann
2023-08-30 12:54 ` Luis Machado
2023-08-22 11:21 ` [PATCH v2 3/6] [gdb/aarch64] sme2: signal frame support Luis Machado
2023-08-27 1:19 ` Thiago Jung Bauermann
2023-08-22 11:21 ` [PATCH v2 4/6] [gdb/aarch64] sme2: Core file support for ZT register set Luis Machado
2023-08-27 1:21 ` Thiago Jung Bauermann
2023-08-30 12:56 ` Luis Machado
2023-08-22 11:21 ` [PATCH v2 5/6] [gdb/testsuite] sme2: Extend SME tests to include SME2 Luis Machado
2023-08-27 1:23 ` Thiago Jung Bauermann
2023-08-30 12:56 ` Luis Machado
2023-08-22 11:21 ` [PATCH v2 6/6] [gdb/docs] sme2: Document SME2 registers and features Luis Machado
2023-08-22 11:34 ` Eli Zaretskii
2023-08-22 11:45 ` Luis Machado
2023-08-27 1:27 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39105c1a-6922-61c4-c615-357b82b6325c@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).