Re: [PATCH v2 1/6] [gdb/aarch64] sme2: Enable SME2 for AArch64 gdb on Linux

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Hello Luis,

I have only one minor nit about this patch. In any case:

Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>

Luis Machado <luis.machado@arm.com> writes:

> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index d7fcef5a0db..edbe6895c86 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -376,6 +376,37 @@ store_za_to_thread (struct regcache *regcache)
>  				     tdep->sme_svcr_regnum);
>  }
>  
> +/* Fill GDB's REGCACHE with the ZT register set contents from the
> +   current thread.  If there is no active ZA register state, make the
> +   ZT register contents zero.  */

Same comment about "current thread" from the SME patch series: the
function uses the regcache's ptid to identify the thread, so it's not
from the current thread that it gets the register values.

> +static void
> +fetch_zt_from_thread (struct regcache *regcache)
> +{
> +  aarch64_gdbarch_tdep *tdep
> +    = gdbarch_tdep<aarch64_gdbarch_tdep> (regcache->arch ());
> +
> +  /* Read ZT state from the thread to the register cache.  */
> +  aarch64_zt_regs_copy_to_reg_buf (regcache->ptid ().lwp (),
> +				   regcache,
> +				   tdep->sme2_zt0_regnum);
> +}
> +
> +/* Store the NT_ARM_ZT register set contents from GDB's REGCACHE to the current
> +   thread.  */

Also here.

> +
> +static void
> +store_zt_to_thread (struct regcache *regcache)
> +{
> +  aarch64_gdbarch_tdep *tdep
> +    = gdbarch_tdep<aarch64_gdbarch_tdep> (regcache->arch ());
> +
> +  /* Write ZT state from the register cache to the thread.  */
> +  aarch64_zt_regs_copy_from_reg_buf (regcache->ptid ().lwp (),
> +				     regcache,
> +				     tdep->sme2_zt0_regnum);
> +}

-- 
Thiago